Troubles with 'exclude_from:' #207

New Issue

Closed

opened 2019-08-23 12:01:08 +00:00 by predmijat · 3 comments

predmijat commented 2019-08-23 12:01:08 +00:00

Copy Link

What I'm trying to do and why

Supply list of exclude patterns from a file

Steps to reproduce (if a bug)

exclude_from:
    - /root/borg/common-exclude

$ cat /root/borg/common-exclude
R /
- /var/www/vhosts/*/httpdocs/wp-content/cache/*
(... some other stuff )

Actual behavior (if a bug)

-rw-r--r-- websiteuser websitegroup 39961 Fri, 2019-08-23 08:36:47 var/www/vhosts/website.com/httpdocs/wp-content/cache/db/singletables/27c/438/27c43859676cb64159242c6f5a0c9276.php is being backed up

Expected behavior (if a bug)

it shouldn't back up patterns found in common-exclude file

Other notes / implementation ideas

Environment

borgmatic version: 1.3.12

borgmatic installation method: pip

Borg version: borg 1.1.9

Python version: Python 3.6.8

operating system and version: CentOS 7

Please tell me what am I missing :)

---

EDIT: so it looks like it doesn't like - when it's in the file :)

#### What I'm trying to do and why Supply list of exclude patterns from a file #### Steps to reproduce (if a bug) ``` exclude_from: - /root/borg/common-exclude ``` ``` $ cat /root/borg/common-exclude R / - /var/www/vhosts/*/httpdocs/wp-content/cache/* (... some other stuff ) ``` #### Actual behavior (if a bug) `-rw-r--r-- websiteuser websitegroup 39961 Fri, 2019-08-23 08:36:47 var/www/vhosts/website.com/httpdocs/wp-content/cache/db/singletables/27c/438/27c43859676cb64159242c6f5a0c9276.php` is being backed up #### Expected behavior (if a bug) it shouldn't back up patterns found in common-exclude file #### Other notes / implementation ideas #### Environment **borgmatic version:** 1.3.12 **borgmatic installation method:** pip **Borg version:** borg 1.1.9 **Python version:** Python 3.6.8 **operating system and version:** CentOS 7 Please tell me what am I missing :) ---- EDIT: so it looks like it doesn't like `-` when it's in the file :)

witten commented 2019-08-23 17:39:57 +00:00

Owner

Copy Link

Thanks for filing this! I think the problem may be that you're using the Borg "patterns" format instead of the expected Borg "excludes" format. So you've got two options:

• Switch from using borgmatic's excludes_from to patterns_from. That way, it'll be able to consume your existing patterns file.
• Or, continue using excludes_from and rewrite your excludes file to be of the expected format. That format is just a series of paths to exclude, no - prefix and no R /.

Let me know if either of those does the trick!

Thanks for filing this! I think the problem may be that you're using the Borg "patterns" format instead of the expected Borg "excludes" format. So you've got two options: * Switch from using borgmatic's `excludes_from` to `patterns_from`. That way, it'll be able to consume your existing patterns file. * Or, continue using `excludes_from` and rewrite your excludes file to be of the expected format. That format is just a series of paths to exclude, no `- ` prefix and no `R /`. Let me know if either of those does the trick!

witten added the

question / support

label 2019-08-23 17:40:03 +00:00

predmijat commented 2019-08-24 07:29:52 +00:00

Author

Copy Link

Thanks for the detailed explanation :)
Problem solved.

Thanks for the detailed explanation :) Problem solved.

predmijat closed this issue 2019-08-24 07:29:52 +00:00

witten commented 2019-08-24 19:53:48 +00:00

Owner

Copy Link

Glad to hear it!

Glad to hear it!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#207

No description provided.