after_backup or on_error hook doesn't work #190

New Issue

Closed

opened 2019-06-15 06:32:41 +00:00 by Plague · 3 comments

Plague commented 2019-06-15 06:32:41 +00:00

Copy Link

I've got hooks in my config.yaml as follows:

hooks:
before_backup:
- borgmatic -c /borgmatic/config.yaml --list --info | mail -s "[Borg] Starting backup job." me@somewhere.com
after_backup:
- borgmatic -c /borgmatic/config.yaml --list --info | mail -s "[Borg] [SUCCESS] Finished backup job." me@somewhere.com
on_error:
- borgmatic -c /borgmatic/config.yaml --list --info | mail -s "[Borg] [ERROR] Backup job failed." me@somewhere.com

"before_backup" hook works fine, but neither "after_backup" or "on_error" does. No error is produced.
I can see: "/borgmatic/config.yaml: Running command for pre-backup hook" with switched on verbose, and e-mail is send fine.
Then after the backup I get: "/borgmatic/config.yaml: Running command for post-backup hook" and nothing happens... No e-mail sent.

Any suggestions?

I've got hooks in my config.yaml as follows: hooks: before_backup: - borgmatic -c /borgmatic/config.yaml --list --info | mail -s "[Borg] Starting backup job." me@somewhere.com after_backup: - borgmatic -c /borgmatic/config.yaml --list --info | mail -s "[Borg] [SUCCESS] Finished backup job." me@somewhere.com on_error: - borgmatic -c /borgmatic/config.yaml --list --info | mail -s "[Borg] [ERROR] Backup job failed." me@somewhere.com "before_backup" hook works fine, but neither "after_backup" or "on_error" does. No error is produced. I can see: "/borgmatic/config.yaml: Running command for pre-backup hook" with switched on verbose, and e-mail is send fine. Then after the backup I get: "/borgmatic/config.yaml: Running command for post-backup hook" and nothing happens... No e-mail sent. Any suggestions?

witten commented 2019-06-15 16:23:25 +00:00

Owner

Copy Link

Novel ideal.. Using borgmatic to invoke borgmatic! A couple of ideas on debugging this: Try borgmatic --verbosity 2 to help debug what exactly is going on with after_backup or on_error hooks. That should show you not only the "Running command for post-backup hook" log line, but also (with recent versions of borgmatic) display the exact hook command being executed. It's possible that borgmatic is invoking the hook, but something about the mail is preventing it from sending.. Have you checked your mail log and/or mail queue?

Also, what version of borgmatic are you using? You can get that with borgmatic --version.

Tangentially related: You may be interested in witten/borgmatic#126 because it looks like you're using the hooks to report on overall archive status.

Novel ideal.. Using borgmatic to invoke borgmatic! A couple of ideas on debugging this: Try `borgmatic --verbosity 2` to help debug what exactly is going on with `after_backup` or `on_error` hooks. That *should* show you not only the "Running command for post-backup hook" log line, but also (with recent versions of borgmatic) display the exact hook command being executed. It's possible that borgmatic is invoking the hook, but something about the mail is preventing it from sending.. Have you checked your mail log and/or mail queue? Also, what version of borgmatic are you using? You can get that with `borgmatic --version`. Tangentially related: You may be interested in https://projects.torsion.org/witten/borgmatic/issues/126 because it looks like you're using the hooks to report on overall archive status.

witten added the

question / support

label 2019-06-15 16:23:33 +00:00

Plague commented 2019-06-15 21:18:19 +00:00

Author

Copy Link

Ok, thanks @witten for an idea. The mystery has been solved.
I run my backups from a docker container. The after_backup or on_error were indeed called, but as they are the final tasks, the container got terminated before the e-mail could be sent. I have added an extra step sleep 10 to both hooks, and everything works like a charm 😃

Ok, thanks @witten for an idea. The mystery has been solved. I run my backups from a docker container. The `after_backup` or `on_error` were indeed called, but as they are the final tasks, the container got terminated before the e-mail could be sent. I have added an extra step `sleep 10` to both hooks, and everything works like a charm :smiley:

Plague closed this issue 2019-06-15 21:18:19 +00:00

witten commented 2019-06-15 21:21:10 +00:00

Owner

Copy Link

Glad that did it! One idea, if you want to sidestep the need for a sleep, is to run your email sending from a separate container (or on the host), so that way it can continue the asynchronous task of email sending even after the borgmatic container exits.

Another idea is to run a persistent borgmatic container, e.g. https://hub.docker.com/r/b3vis/borgmatic/

Glad that did it! One idea, if you want to sidestep the need for a sleep, is to run your email sending from a separate container (or on the host), so that way it can continue the asynchronous task of email sending even after the borgmatic container exits. Another idea is to run a persistent borgmatic container, e.g. https://hub.docker.com/r/b3vis/borgmatic/

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#190

No description provided.