Also read .yml file endings #178

New Issue

Closed

opened 2019-05-16 19:39:41 +00:00 by decentral1se · 5 comments

decentral1se commented 2019-05-16 19:39:41 +00:00

Contributor

Copy Link

AFAICT, these don't get picked up and AFAICT, they should :) A lot of tools that deal with YAML do both. I don't know the history about this but this might be a bad experience for users who are used to being able to use these file endings types interchangeably.

AFAICT, these don't get picked up and AFAICT, they should :) A lot of tools that deal with YAML do both. I don't know the history about this but this might be a bad experience for users who are used to being able to use these file endings types interchangeably.

decentral1se commented 2019-05-16 19:40:16 +00:00

Author

Contributor

Copy Link

Can submit a PR if we're all in agreement.

Can submit a PR if we're all in agreement.

witten commented 2019-05-16 19:47:27 +00:00

Owner

Copy Link

Can you say more or give some repro steps on where you'll seeing .yml file endings not getting picked up? As far as I know, there's nothing in the borgmatic code that even cares about the filename.. just the contents.

Thanks!

Can you say more or give some repro steps on where you'll seeing `.yml` file endings not getting picked up? As far as I know, there's nothing in the borgmatic code that even cares about the filename.. just the contents. Thanks!

witten commented 2019-05-16 19:49:07 +00:00

Owner

Copy Link

Oh, I think I found a spot that does care:

borgmatic/config/collect.py:46:
if full_filename.endswith('.yaml') and not os.path.isdir(full_filename):

A PR would be most welcome!

Oh, I think I found a spot that does care: ```python borgmatic/config/collect.py:46: if full_filename.endswith('.yaml') and not os.path.isdir(full_filename): ``` A PR would be most welcome!

witten added the

design finalized

label 2019-05-17 23:32:26 +00:00

witten commented 2019-05-19 21:17:51 +00:00

Owner

Copy Link

Thank you!

Thank you!

witten closed this issue 2019-05-19 21:17:51 +00:00

witten commented 2019-06-14 05:07:15 +00:00

Owner

Copy Link

Just released as part of borgmatic 1.3.6. Enjoy!

Just released as part of borgmatic 1.3.6. Enjoy!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#178

No description provided.