Verbose logging missing log entries #177

Closed
opened 2019-05-16 17:29:54 +00:00 by witten · 5 comments
Owner

It appears that verbose logging (both levels) has regressed such that many log entries are no longer showing up in the output. For instance, -v 2 used to show the Borg commands being run, and it no longer does.

I imagine this was a regression introduced by colored log output (#125).

It appears that verbose logging (both levels) has regressed such that many log entries are no longer showing up in the output. For instance, `-v 2` used to show the Borg commands being run, and it no longer does. I imagine this was a regression introduced by colored log output (#125).
witten added the
bug
label 2019-05-16 17:29:59 +00:00
Author
Owner

I think I've tracked this down to the addition of logger.propagate = False in this PR: witten/borgmatic#164

@decentral1se

I think I've tracked this down to the addition of `logger.propagate = False` in this PR: https://projects.torsion.org/witten/borgmatic/pulls/164 @decentral1se
Contributor

Aha, apologies there. I think that = False came from my copy/pasta from another project. Should have taken a bit more time to manually test this ... nice detective work!

Aha, apologies there. I think that `= False` came from my copy/pasta from another project. Should have taken a bit more time to manually test this ... nice detective work!
Author
Owner

No worries! Without = False, there's now a lot more cool colored output!

No worries! Without `= False`, there's now a lot more cool colored output!
Author
Owner

Fix released with borgmatic 1.3.5!

Fix released with borgmatic 1.3.5!
Contributor

🚀 🚀 🚀

:rocket: :rocket: :rocket:
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#177
No description provided.