Small suggestion for default "echo date" #127

Closed
opened 2018-12-29 14:35:04 +00:00 by patricko · 6 comments

Replace the default echo date by this
echo "[date +"%e/%m/%Y | %^A | %H:%M:%S"]

(try it in your terminal)

Feel free to add it or close the issue :P

Replace the default echo date by this echo "[`date +"%e/%m/%Y | %^A | %H:%M:%S"`] (try it in your terminal) Feel free to add it or close the issue :P
Owner

I'm not sure where you're talking about.. Can you clarify? For instance, I see that there's a hooks example in the schema (and therefore in the generated config) with things like:
echo "date - Starting a backup job."
.. But that's just an example. Is that what you're referring to?

And what's your motivation in suggesting the altered format? Thanks.

I'm not sure where you're talking about.. Can you clarify? For instance, I see that there's a hooks example in the schema (and therefore in the generated config) with things like: echo "`date` - Starting a backup job." .. But that's just an example. Is that what you're referring to? And what's your motivation in suggesting the altered format? Thanks.
Author

yes, that's for this part and the idea is to make it more readable but as you wish

yes, that's for this part and the idea is to make it more readable but as you wish
Owner

Yeah, I think the ultimate solution is to implement real logging as per #53. That way we'd get full timestamp configuration support of whatever logging solution is used. And then perhaps even removing the date portion of these example echos.

Yeah, I think the ultimate solution is to implement real logging as per #53. That way we'd get full timestamp configuration support of whatever logging solution is used. And then perhaps even removing the `date` portion of these example echos.
Author

Feel free to change the default borgmatic with my version of date or not, closing the issue

Feel free to change the default borgmatic with my version of date or not, closing the issue
Owner

I went ahead and just removed the date echo entirely so as to sidestep the issue. I think that #53 (actual logging) will be the "real" solution.

I went ahead and just removed the date echo entirely so as to sidestep the issue. I think that #53 (actual logging) will be the "real" solution.
Author

I think you should delete it only when it's being replaced but fine :D

I think you should delete it only when it's being replaced but fine :D
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#127
No description provided.