Create borgmatic.d/ during default installation #120

Closed
opened 2018-12-20 12:28:53 +00:00 by patricko · 4 comments

I just realized we could do this, but if it were created during installation, I'd found it long ago!

Why not creating it by default?

I just realized we could do this, but if it were created during installation, I'd found it long ago! Why not creating it by default?
Owner

Probably no good reason.. My guess is that it's historical.. generate-borgmatic-config was written before the borgmatic.d feature existed.

Good idea!

Probably no good reason.. My guess is that it's historical.. `generate-borgmatic-config` was written before the `borgmatic.d` feature existed. Good idea!
witten added the
design finalized
label 2019-02-05 18:26:35 +00:00
Contributor

Just my two cents, what is the purpose of having both /etc/borgmatic and /etc/borgmatic.d ? Wouldn't it be simpler to completely remove /etc/borgmatic and just keep /etc/borgmatic.d ?

Just my two cents, what is the purpose of having both `/etc/borgmatic` and `/etc/borgmatic.d` ? Wouldn't it be simpler to completely remove `/etc/borgmatic` and just keep `/etc/borgmatic.d` ?
Owner

While you're entirely correct that /etc/borgmatic.d/ could handle both cases, /etc/borgmatic/ is more for the "common case" of just having a single config file. Slightly nicer user experience, I guess.

Also, the code that supports both /etc/borgmatic/ and /etc/borgmatic.d/ has to be there anyway, since the user can provide multiple custom config file paths on the command-line with the --config flag.

While you're entirely correct that `/etc/borgmatic.d/` could handle both cases, `/etc/borgmatic/` is more for the "common case" of just having a single config file. Slightly nicer user experience, I guess. Also, the code that supports both `/etc/borgmatic/` and `/etc/borgmatic.d/` has to be there anyway, since the user can provide multiple custom config file paths on the command-line with the `--config` flag.
Owner

I decided not to do this as written, because there isn't a clean or universal way to run arbitrary commands (like making a directory) when borgmatic gets installed by pip or the system package manager. Instead, I opted to put this how-to guide mentioning /etc/borgmatic.d/ prominently on the borgmatic home page: https://torsion.org/borgmatic/docs/how-to/make-per-application-backups/ .. I hope that works!

I decided not to do this as written, because there isn't a clean or universal way to run arbitrary commands (like making a directory) when borgmatic gets installed by pip or the system package manager. Instead, I opted to put this how-to guide mentioning `/etc/borgmatic.d/` prominently on the borgmatic home page: https://torsion.org/borgmatic/docs/how-to/make-per-application-backups/ .. I hope that works!
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#120
No description provided.