#120 Create borgmatic.d/ during default installation

Chiuso
aperto 10 mesi fa da patrick_stronn · 4 commenti
patrick_stronn 10 mesi fa ha commentato

I just realized we could do this, but if it were created during installation, I’d found it long ago!

Why not creating it by default?

I just realized we could do this, but if it were created during installation, I'd found it long ago! Why not creating it by default?
witten 10 mesi fa ha commentato
Proprietario

Probably no good reason.. My guess is that it’s historical.. generate-borgmatic-config was written before the borgmatic.d feature existed.

Good idea!

Probably no good reason.. My guess is that it's historical.. `generate-borgmatic-config` was written before the `borgmatic.d` feature existed. Good idea!
witten added the
design finalized
label 8 mesi fa
nicoulaj 8 mesi fa ha commentato

Just my two cents, what is the purpose of having both /etc/borgmatic and /etc/borgmatic.d ? Wouldn’t it be simpler to completely remove /etc/borgmatic and just keep /etc/borgmatic.d ?

Just my two cents, what is the purpose of having both `/etc/borgmatic` and `/etc/borgmatic.d` ? Wouldn't it be simpler to completely remove `/etc/borgmatic` and just keep `/etc/borgmatic.d` ?
witten 8 mesi fa ha commentato
Proprietario

While you’re entirely correct that /etc/borgmatic.d/ could handle both cases, /etc/borgmatic/ is more for the “common case” of just having a single config file. Slightly nicer user experience, I guess.

Also, the code that supports both /etc/borgmatic/ and /etc/borgmatic.d/ has to be there anyway, since the user can provide multiple custom config file paths on the command-line with the --config flag.

While you're entirely correct that `/etc/borgmatic.d/` could handle both cases, `/etc/borgmatic/` is more for the "common case" of just having a single config file. Slightly nicer user experience, I guess. Also, the code that supports both `/etc/borgmatic/` and `/etc/borgmatic.d/` has to be there anyway, since the user can provide multiple custom config file paths on the command-line with the `--config` flag.
witten 6 mesi fa ha commentato
Proprietario

I decided not to do this as written, because there isn’t a clean or universal way to run arbitrary commands (like making a directory) when borgmatic gets installed by pip or the system package manager. Instead, I opted to put this how-to guide mentioning /etc/borgmatic.d/ prominently on the borgmatic home page: https://torsion.org/borgmatic/docs/how-to/make-per-application-backups/ .. I hope that works!

I decided not to do this as written, because there isn't a clean or universal way to run arbitrary commands (like making a directory) when borgmatic gets installed by pip or the system package manager. Instead, I opted to put this how-to guide mentioning `/etc/borgmatic.d/` prominently on the borgmatic home page: https://torsion.org/borgmatic/docs/how-to/make-per-application-backups/ .. I hope that works!
Effettua l'accesso per partecipare alla conversazione.
Nessuna milestone
No Assignees
3 Partecipanti
Data di scadenza

Nessuna data di scadenza impostata.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Annulla
Salva
Non ci sono ancora contenuti.