blows up when the % character is used in a passphrase #12

New Issue

Closed

opened 2018-01-05 05:33:38 +00:00 by import_bot · 2 comments

import_bot commented 2018-01-05 05:33:38 +00:00

Collaborator

Copy Link

when using the new encryption_passphrase option if there is a '%' character in the value we get a exception:

borgmatic
Traceback (most recent call last):
File "/usr/local/bin/borgmatic", line 9, in
load_entry_point('atticmatic==0.1.6', 'console_scripts', 'borgmatic')()
File "/usr/local/lib/python3.4/dist-packages/atticmatic/command.py", line 64, in main
config = parse_configuration(args.config_filename, backend.CONFIG_FORMAT)
File "/usr/local/lib/python3.4/dist-packages/atticmatic/config.py", line 123, in parse_configuration
for section_format in config_format
File "/usr/local/lib/python3.4/dist-packages/atticmatic/config.py", line 123, in
for section_format in config_format
File "/usr/local/lib/python3.4/dist-packages/atticmatic/config.py", line 99, in parse_section_options
for option in section_format.options
File "/usr/lib/python3.4/collections/init.py", line 56, in init
self.__update(*args, **kwds)
File "/usr/lib/python3.4/_collections_abc.py", line 583, in update
for key, value in other:
File "/usr/local/lib/python3.4/dist-packages/atticmatic/config.py", line 100, in
if parser.has_option(section_format.name, option.name)
File "/usr/lib/python3.4/configparser.py", line 773, in get
d)
File "/usr/lib/python3.4/configparser.py", line 374, in before_get
self._interpolate_some(parser, option, L, value, section, defaults, 1)
File "/usr/lib/python3.4/configparser.py", line 423, in _interpolate_some
"found: %r" % (rest,))
configparser.InterpolationSyntaxError: '%' must be followed by '%' or '(', found: 'somelongpasswordwith%init'

---

Imported from Taiga issue 11 (done). Created on 2015-09-03T21:09:23+0000 by Dennis Roberts.

when using the new encryption_passphrase option if there is a '%' character in the value we get a exception: borgmatic Traceback (most recent call last): File "/usr/local/bin/borgmatic", line 9, in <module> load_entry_point('atticmatic==0.1.6', 'console_scripts', 'borgmatic')() File "/usr/local/lib/python3.4/dist-packages/atticmatic/command.py", line 64, in main config = parse_configuration(args.config_filename, backend.CONFIG_FORMAT) File "/usr/local/lib/python3.4/dist-packages/atticmatic/config.py", line 123, in parse_configuration for section_format in config_format File "/usr/local/lib/python3.4/dist-packages/atticmatic/config.py", line 123, in <genexpr> for section_format in config_format File "/usr/local/lib/python3.4/dist-packages/atticmatic/config.py", line 99, in parse_section_options for option in section_format.options File "/usr/lib/python3.4/collections/__init__.py", line 56, in __init__ self.__update(*args, **kwds) File "/usr/lib/python3.4/_collections_abc.py", line 583, in update for key, value in other: File "/usr/local/lib/python3.4/dist-packages/atticmatic/config.py", line 100, in <genexpr> if parser.has_option(section_format.name, option.name) File "/usr/lib/python3.4/configparser.py", line 773, in get d) File "/usr/lib/python3.4/configparser.py", line 374, in before_get self._interpolate_some(parser, option, L, value, section, defaults, 1) File "/usr/lib/python3.4/configparser.py", line 423, in _interpolate_some "found: %r" % (rest,)) configparser.InterpolationSyntaxError: '%' must be followed by '%' or '(', found: 'somelongpasswordwith%init' --- Imported from Taiga issue 11 (done). Created on 2015-09-03T21:09:23+0000 by Dennis Roberts.

import_bot closed this issue 2018-01-05 05:33:38 +00:00

import_bot added the

bug

label 2018-01-05 05:33:39 +00:00

import_bot commented 2018-01-05 05:33:39 +00:00

Author

Collaborator

Copy Link

Looks like this a limitation of the built-in Python ConfigParser we're using, in that it's trying to do variable interpolation when it hits the "%" character: https://docs.python.org/2/library/configparser.html#ConfigParser.ConfigParser

The fix might be switching to the RawConfigParser.

---

Comment on 2015-09-04T04:19:55+0000 by Dan Helfman.

Looks like this a limitation of the built-in Python ConfigParser we're using, in that it's trying to do variable interpolation when it hits the "%" character: https://docs.python.org/2/library/configparser.html#ConfigParser.ConfigParser The fix might be switching to the RawConfigParser. --- Comment on 2015-09-04T04:19:55+0000 by Dan Helfman.

import_bot commented 2018-01-05 05:33:40 +00:00

Author

Collaborator

Copy Link

This should be fixed in release 0.1.7, now available.

---

Comment on 2015-09-06T23:41:04+0000 by Dan Helfman.

This should be fixed in release 0.1.7, now available. --- Comment on 2015-09-06T23:41:04+0000 by Dan Helfman.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#12

No description provided.