[Enhancement] verbosity with --progess #108

Closed
opened 2018-11-17 15:17:18 +00:00 by Stunkymonkey · 6 comments
Contributor

i realy like, that #64 is fixed.

but i still miss the feature having another verbosity level with borg create --progress

in my opinion it should be added to verbosity-level one.

i realy like, that #64 is fixed. but i still miss the feature having another verbosity level with `borg create --progress` in my opinion it should be added to verbosity-level one.
Owner

What do you think of the idea proposed on #106? Basically:

The way I could imagine that working is to add an optional --progress to the borgmatic command-line that basically triggers the built-in Borg progress bar.

If that works, then I could close this ticket in favor of #106 and implement the progress bar there.

What do you think of the idea proposed on #106? Basically: > The way I could imagine that working is to add an optional --progress to the borgmatic command-line that basically triggers the built-in Borg progress bar. If that works, then I could close this ticket in favor of #106 and implement the progress bar there.
Author
Contributor

seems a bit like it.

i thought the #106 is especially about a progress bar. --progess is not displaying a bar, but the current status.

but your solution (passing the parameter) seems fine to fix this issue.

seems a bit like it. i thought the #106 is especially about a progress **bar**. `--progess` is not displaying a bar, but the current status. but your solution (passing the parameter) seems fine to fix this issue.
Owner

Oh gotcha. I didn't realize --progress wasn't an actual progress bar.. I guess I was assuming it would work like rsync --progress, which isn't a valid assumption.

I'll play around with the flag and figure out if it makes more sense included at borgmatic verbosity level one (as you originally suggested), or as a separate flag.

Oh gotcha. I didn't realize `--progress` wasn't an actual progress bar.. I guess I was assuming it would work like `rsync --progress`, which isn't a valid assumption. I'll play around with the flag and figure out if it makes more sense included at borgmatic verbosity level one (as you originally suggested), or as a separate flag.
Owner

So I played with the flag a bit. My main concern with including it by default (at, say, verbosity level one) is that the updating display may not play nicely with or be overly verbose in a non-interactive display. For instance, if you're redirecting verbose borgmatic output to logs or using it in a cronjob, then --progress could make that log output less useful.

If you buy that, then that leaves the command-line --progress pass-through flag. I also considered a borgmatic configuration option instead, but whether you want to see progress seems more like a temporary display concern (like verbosity is) rather than something you'd want hard-coded in a config file.

Let me know what you think.

So I played with the flag a bit. My main concern with including it by default (at, say, verbosity level one) is that the updating display may not play nicely with or be overly verbose in a non-interactive display. For instance, if you're redirecting verbose borgmatic output to logs or using it in a cronjob, then `--progress` could make that log output less useful. If you buy that, then that leaves the command-line `--progress` pass-through flag. I also considered a borgmatic configuration option instead, but whether you want to see progress seems more like a temporary display concern (like verbosity is) rather than something you'd want hard-coded in a config file. Let me know what you think.
Author
Contributor

Valid argument.

Having a seperate (pass-through) parameter would be perfect.

Valid argument. Having a seperate (pass-through) parameter would be perfect.
witten added the
design finalized
label 2018-11-19 04:14:00 +00:00
Owner

Released in borgmatic 1.2.11. Enjoy!

Released in borgmatic 1.2.11. Enjoy!
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#108
No description provided.