timvahlbrock
  • Joined on 2021-12-06
timvahlbrock commented on issue borgmatic-collective/borgmatic#473 2022-02-06 00:12:26 +00:00
Hooks are all executed at the same time.

So you're proposing to adapt the current behavior of the hooks? As far as I'm concerned, that would be a breaking change for some existing configurations. Right?

timvahlbrock commented on issue borgmatic-collective/borgmatic#473 2021-12-08 11:12:57 +00:00
Hooks are all executed at the same time.

What i forgot: the result.

Could be implemented in a similar fashion to task and timing, but will only be allowed if timing is after or afterAll or any. Possible values: `success

timvahlbrock commented on issue borgmatic-collective/borgmatic#473 2021-12-08 10:45:05 +00:00
Hooks are all executed at the same time.

Alternate Syntax I think we have a conflict between ease of configuration and versatility of the configuration. Maybe this can be resolved with a syntax like this (here for the pausing/unpausing…

timvahlbrock commented on issue borgmatic-collective/borgmatic#475 2021-12-08 10:08:22 +00:00
on_error hook needs corresponding on_success hook

What about covering this with #473?

timvahlbrock commented on issue borgmatic-collective/borgmatic#473 2021-12-06 13:11:33 +00:00
Hooks are all executed at the same time.

Maybe the current behavior could be achieved with an alternate syntax like:

hooks:
  before_everything:
    if_prune:
      - echo "Start of all actions, prune will be performed."