real-or-random
  • Joined on 2022-06-30
real-or-random closed pull request borgmatic-collective/borgmatic#1178 2025-11-18 08:59:26 +00:00
Don't expand XDG_CONFIG_HOME if not expanding HOME in default config paths
real-or-random commented on pull request borgmatic-collective/borgmatic#1178 2025-11-18 08:59:26 +00:00
Don't expand XDG_CONFIG_HOME if not expanding HOME in default config paths

Closing in favor of #1184.

real-or-random commented on pull request borgmatic-collective/borgmatic#1184 2025-11-18 08:59:02 +00:00
Hard-code default config paths in help strings

The only thing I'd recommend tweaking is how you display the default paths on the command-line.

Added a commit that does this.

Ready for merge from my side.

real-or-random pushed to 202511-fix-fish-completions2 at real-or-random/borgmatic 2025-11-18 08:57:47 +00:00
ea45a37db8 Omit "-c" when describing default value for -c
real-or-random commented on pull request borgmatic-collective/borgmatic#1184 2025-11-17 14:48:08 +00:00
Hard-code default config paths in help strings

If you ask me, this approach here indeed looks better. It simplifies the code, both in terms of complexity and in terms of lines of code. The cost is that the code is a bit less DRY. But I think…

real-or-random commented on pull request borgmatic-collective/borgmatic#1178 2025-11-17 14:47:18 +00:00
Don't expand XDG_CONFIG_HOME if not expanding HOME in default config paths

Indeed, it's a "fun" one... Now that I think about this again, one interpretation of that edge case is that having expand_home for the docs might be a bit over-engineered. As an alternative…

real-or-random created pull request borgmatic-collective/borgmatic#1184 2025-11-17 14:44:44 +00:00
Hard-code default config paths in help strings
real-or-random pushed to 202511-fix-fish-completions2 at real-or-random/borgmatic 2025-11-17 14:43:42 +00:00
573405bb88 Hard-code default config paths in help strings
real-or-random created branch 202511-fix-fish-completions2 in real-or-random/borgmatic 2025-11-17 14:43:42 +00:00
real-or-random commented on pull request borgmatic-collective/borgmatic#1178 2025-11-17 14:22:49 +00:00
Don't expand XDG_CONFIG_HOME if not expanding HOME in default config paths

If I understand correctly, this is handled by parse_configuration() in borgmatic/commands/arguments.py instead. And that function restricts it to values read and config files, handles…

real-or-random commented on pull request borgmatic-collective/borgmatic#1178 2025-11-11 20:25:47 +00:00
Don't expand XDG_CONFIG_HOME if not expanding HOME in default config paths

That's quite an annoying edge case you've discovered!

Indeed, it's a "fun" one... Now that I think about this again, one interpretation of that edge case is that having expand_home for the…

real-or-random commented on pull request borgmatic-collective/borgmatic#1178 2025-11-08 09:07:09 +00:00
Don't expand XDG_CONFIG_HOME if not expanding HOME in default config paths

I see. Let me try to fix the tests.

real-or-random pushed to 202511-fix-fish-completions at real-or-random/borgmatic 2025-11-07 14:52:21 +00:00
87dec0624b Don't expand XDG_CONFIG_HOME if not expanding HOME in default config paths
real-or-random created pull request borgmatic-collective/borgmatic#1178 2025-11-07 14:48:11 +00:00
Don't expand XDG_CONFIG_HOME if not expanding HOME in default config paths
real-or-random created branch 202511-fix-fish-completions in real-or-random/borgmatic 2025-11-07 14:45:39 +00:00
real-or-random pushed to 202511-fix-fish-completions at real-or-random/borgmatic 2025-11-07 14:45:39 +00:00
146d27149c Don't expand XDG_CONFIG_HOME if not expanding HOME in default config paths
real-or-random created repository real-or-random/borgmatic 2025-11-07 14:00:04 +00:00
real-or-random commented on issue borgmatic-collective/borgmatic#571 2022-08-22 08:52:11 +00:00
Misleading arg name: borgmatic prune --files runs borg prune --list

Awesome, thanks! Let's hope it won't break too many old configs. ;)

real-or-random commented on issue borgmatic-collective/borgmatic#571 2022-08-10 10:11:08 +00:00
Misleading arg name: borgmatic prune --files runs borg prune --list

On point 2, the intent with --files is that (for create), it does more than just --list, it also passes a --filter argument to Borg so that it doesn't show all file types by…

real-or-random commented on issue borgmatic-collective/borgmatic#571 2022-08-09 12:44:57 +00:00
Misleading arg name: borgmatic prune --files runs borg prune --list

Just noticed that borg create has also --list but apparently we cover this via verbosity. Related: borgmatic-collective/borgmatic#195