pizzapim
  • Joined on 2023-06-19
pizzapim commented on issue borgmatic-collective/borgmatic#766 2023-10-08 10:09:18 +00:00
Nix development environment?

Yeah, I don't think there is a ready way to automate synchronization between setup.py and the Nix flake. So if any dependencies are updated, they would need to be updated in the flake configurati…

pizzapim opened issue borgmatic-collective/borgmatic#766 2023-10-05 13:58:32 +00:00
Nix development environment?
pizzapim pushed to nix-dev-env at pizzapim/borgmatic 2023-10-05 13:49:36 +00:00
2a32b7983d add nix development environment
pizzapim created branch nix-dev-env in pizzapim/borgmatic 2023-10-05 13:49:36 +00:00
pizzapim created pull request borgmatic-collective/borgmatic#765 2023-10-05 13:42:18 +00:00
Add apprise logo to integrations in readme
pizzapim pushed to documentation-apprise-logo at pizzapim/borgmatic 2023-10-05 13:39:03 +00:00
a83282faf0 add apprise logo to integrations in readme
pizzapim created branch documentation-apprise-logo in pizzapim/borgmatic 2023-10-05 13:39:03 +00:00
pizzapim commented on pull request borgmatic-collective/borgmatic#759 2023-10-04 11:21:55 +00:00
Support for Apprise

I think I fixed the tests with your comments.

I played around with this StackOverflow answer but ultimately couldn't get the import mock to work: https://stackoverflow.com/questions/2481511/mock

pizzapim pushed to main at pizzapim/borgmatic 2023-10-04 11:19:49 +00:00
7a9625cd44 fix PR comments
pizzapim pushed to main at pizzapim/borgmatic 2023-10-04 11:18:28 +00:00
6856c3e465 fix PR comments
pizzapim commented on pull request borgmatic-collective/borgmatic#759 2023-10-01 17:13:32 +00:00
Support for Apprise

@witten I added some unit tests, I hope they are sufficient! Tox reports no failure (except a spelling error somewhere else). I also rebased my branch to master. I'm fine with you doing the…

pizzapim pushed to main at pizzapim/borgmatic 2023-10-01 17:00:01 +00:00
4763c323d0 add unit tests for apprise hook
eaa22be3db fix PR comments
a587e207f9 pin Apprise dependencies for test requirements
db8079b699 fix typo in setup.py
5a989826a1 convert map to list for apprise function call
Compare 12 commits »
pizzapim commented on pull request borgmatic-collective/borgmatic#759 2023-10-01 16:54:39 +00:00
Support for Apprise

Exactly like you said, the function returns either a Boolean or None

pizzapim pushed to main at pizzapim/borgmatic 2023-10-01 16:52:45 +00:00
c3678f10a6 add unit tests for apprise hook
pizzapim pushed to main at pizzapim/borgmatic 2023-10-01 15:00:48 +00:00
e09e197af0 fix PR comments
pizzapim commented on pull request borgmatic-collective/borgmatic#759 2023-09-25 08:47:14 +00:00
Support for Apprise

Thanks for the comments, I think the current PR is ready to be merged then or do you have additional comments?

pizzapim pushed to main at pizzapim/borgmatic 2023-09-25 08:23:46 +00:00
c9b430aa70 pin Apprise dependencies for test requirements
pizzapim pushed to main at pizzapim/borgmatic 2023-09-25 08:19:13 +00:00
1795a78c1c fix typo in setup.py
pizzapim commented on pull request borgmatic-collective/borgmatic#759 2023-09-23 19:55:37 +00:00
Support for Apprise

@witten One more question, how should I pin the versions of Apprise's dependencies? Sorry for the newb questions, never worked at a Python project outside of university :)

pizzapim commented on pull request borgmatic-collective/borgmatic#759 2023-09-23 19:54:07 +00:00
Support for Apprise

Thanks for your invaluable comments :) I have amended my code. I agree, let's start with having only default notification types. If necessary, it can be easily added back in. Regarding the…