An error occurred while parsing a configuration file at /XXX/borgmatic/config.yaml: At 'hooks.cronitor': None is not of type 'object'
Thanks, that's definitely more effecient.
I think that should be covered by default yaml configuration. It should error out cause cronitor is now None.
I've pushed some basic code to define the schema. Can you verify the method I've used?
The reason I wanted to allow specifying ping_url was so if someone wants to get notified on every action on same url, they won't have to specify same link 4 times.
URL construction will happen…
@witten I was going for a schema config like
cronitor:
type: object
additionalProperties: false
oneOf:
- required:
- ping_url
properties:
ping_url:
…
It seems --first
and --last
flags are not implemented for some actions like check
and prune
. Should I add these timespan flags to such actions?
There's no need to enforce that they…
@witten I want to take a pick at this. @rsyring's schema looks good to me.
We can check if cronitor is string or contains sub config to decide url per command.
Do you have any input before…
@witten That's perfect. I requested for you to be added to my proposal discussion.
I'm looking at tasks which can help me get familiar with the codebase while making meaning contributions.…
@diivi This would have been my first contribution to borgmatic so I started working on it before getting this assigned to make sure I can actually complete it. I had no idea about the codebase…
@diivi I do have some code ready. I think we have conflicting projects in proposals too. Let me get back to you.
Can you assign this to me? I'd like to implement @brskq's ideas.