jetchirag
  • Joined on 2023-03-22
jetchirag pushed to action-based-monitor-endpoints at jetchirag/borgmatic 2023-03-25 14:34:35 +00:00
c3cc5cc95c Minor bug fixes, removed debug print and restored cronitor description in schema
jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-25 14:33:08 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

An error occurred while parsing a configuration file at /XXX/borgmatic/config.yaml: At 'hooks.cronitor': None is not of type 'object'

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-25 14:32:02 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

Thanks, that's definitely more effecient.

jetchirag commented on pull request borgmatic-collective/borgmatic#660 2023-03-25 14:23:04 +00:00
WIP: Separate endpoint for each primary action for monitor hooks

I think that should be covered by default yaml configuration. It should error out cause cronitor is now None.

jetchirag commented on issue borgmatic-collective/borgmatic#518 2023-03-25 13:40:51 +00:00
Different health check endpoints for different commands

I've pushed some basic code to define the schema. Can you verify the method I've used?

jetchirag created pull request borgmatic-collective/borgmatic#660 2023-03-25 13:38:03 +00:00
Initial schema modification and ping_monitor params changes
jetchirag created branch action-based-monitor-endpoints in jetchirag/borgmatic 2023-03-25 13:35:07 +00:00
jetchirag pushed to action-based-monitor-endpoints at jetchirag/borgmatic 2023-03-25 13:35:07 +00:00
e87ebab625 Initial schema modification and ping_monitor params changes
jetchirag commented on issue borgmatic-collective/borgmatic#518 2023-03-25 04:23:43 +00:00
Different health check endpoints for different commands

The reason I wanted to allow specifying ping_url was so if someone wants to get notified on every action on same url, they won't have to specify same link 4 times.

URL construction will happen…

jetchirag commented on issue borgmatic-collective/borgmatic#518 2023-03-24 14:51:13 +00:00
Different health check endpoints for different commands

@witten I was going for a schema config like

cronitor:
  type: object
  additionalProperties: false
  oneOf:
    - required:
        - ping_url
      properties:
        ping_url:
…
jetchirag commented on issue borgmatic-collective/borgmatic#659 2023-03-24 08:05:37 +00:00
Borg 2 date-based matching flags for archive selection

It seems --first and --last flags are not implemented for some actions like check and prune. Should I add these timespan flags to such actions?

There's no need to enforce that they…

jetchirag commented on issue borgmatic-collective/borgmatic#659 2023-03-24 04:10:42 +00:00
Borg 2 date-based matching flags for archive selection

I'll check this one.

jetchirag commented on issue borgmatic-collective/borgmatic#326 2023-03-23 21:47:42 +00:00
Allow restoring to other database server

@witten Thank you! I'm checking them.

jetchirag commented on issue borgmatic-collective/borgmatic#518 2023-03-23 05:22:16 +00:00
Different health check endpoints for different commands

@witten I want to take a pick at this. @rsyring's schema looks good to me.

We can check if cronitor is string or contains sub config to decide url per command.

Do you have any input before…

jetchirag commented on issue borgmatic-collective/borgmatic#326 2023-03-23 05:00:37 +00:00
Allow restoring to other database server

@witten That's perfect. I requested for you to be added to my proposal discussion.

I'm looking at tasks which can help me get familiar with the codebase while making meaning contributions.…

jetchirag commented on issue borgmatic-collective/borgmatic#326 2023-03-23 04:56:10 +00:00
Allow restoring to other database server

@diivi This would have been my first contribution to borgmatic so I started working on it before getting this assigned to make sure I can actually complete it. I had no idea about the codebase…

jetchirag commented on issue borgmatic-collective/borgmatic#326 2023-03-22 19:00:55 +00:00
Allow restoring to other database server

@diivi I do have some code ready. I think we have conflicting projects in proposals too. Let me get back to you.

jetchirag commented on issue borgmatic-collective/borgmatic#326 2023-03-22 17:14:04 +00:00
Allow restoring to other database server

Can you assign this to me? I'd like to implement @brskq's ideas.

jetchirag created repository jetchirag/borgmatic 2023-03-22 14:52:23 +00:00