holocronweaver

holocronweaver commented on pull request borgmatic-collective/borgmatic#683

2023-04-21 05:53:51 +00:00

Expand source directories when checking for existence.

Rebased and removed WIP tag, should be good merge. Thanks for the speedy review!

holocronweaver pushed to master at holocronweaver/borgmatic

2023-04-21 05:52:05 +00:00

a14870ce48 Expand source directories when checking for existence (#682).

ee5c25f3bd Add additional tests for PostgreSQL hook fixes (#678).

da0f5a34f2 Fix multiple bugs in PostgreSQL hook (#678).

17f122bfe5 Use psql instead of pg_restore when format is "plain"

f0f43174c6 Swap if-else in restore_database_dump in postgresql hook for cleanliness

Compare 9 commits »

holocronweaver commented on issue borgmatic-collective/borgmatic#684

2023-04-21 02:30:08 +00:00

Rename 'master' branch

Wow, that was fast! Thanks so much for the quick change.

BTW, not sure if it was related to branch name changes, but noticed the commit log messages for podman-in-podman issues. It was a web…

holocronweaver pushed to master at holocronweaver/borgmatic

2023-04-21 02:27:22 +00:00

1fdbfec04d Expand source directories when checking for existence (#682).

065be1d9d4 More inclusive language.

f2f6fb537a !!!

7ff994a964 🤦

08edecacae WTF?!

Compare 27 commits »

holocronweaver commented on pull request borgmatic-collective/borgmatic#683

2023-04-21 02:22:43 +00:00

Expand source directories when checking for existence.

Updated PR based on feedback, things are looking cleaner now thanks to your suggestions. 😄

Verified again that test fails with original check_all_source_directories_exist function and…

holocronweaver pushed to master at holocronweaver/borgmatic

2023-04-21 02:15:24 +00:00

31e5d3c0b1 Expand source directories when checking for existence.

holocronweaver commented on pull request borgmatic-collective/borgmatic#683

2023-04-21 02:14:16 +00:00

Expand source directories when checking for existence.

Will switch from integ to unit test, which will definitely be simpler and more pointed. I was trying to copy the style of the only test I saw using source_directories_must_exist, without reading…

holocronweaver commented on pull request borgmatic-collective/borgmatic#683

2023-04-21 02:09:10 +00:00

Expand source directories when checking for existence.

Fair enough! Will switch to list comprehension to better fit existing code style. Agree it is more readable, which is the common case so makes sense to optimize style for it.

holocronweaver pushed to master at holocronweaver/borgmatic

2023-04-21 02:01:00 +00:00

2741160a45 Expand source directories when checking for existence.

holocronweaver opened issue borgmatic-collective/borgmatic#684

2023-04-20 02:14:51 +00:00

Rename 'master' branch

holocronweaver created pull request borgmatic-collective/borgmatic#683

2023-04-20 01:56:58 +00:00

WIP: Expand source directories when checking for existence.

holocronweaver pushed to master at holocronweaver/borgmatic

2023-04-20 01:55:46 +00:00

56ff38f09f Expand source directories when checking for existence.

holocronweaver pushed to master at holocronweaver/borgmatic

2023-04-20 01:55:23 +00:00

dcc4ac4154 Expand soruce directories when checking for existence.

holocronweaver pushed to master at holocronweaver/borgmatic

2023-04-20 01:53:25 +00:00

2447b29664 Expand directories when checking for existence.

holocronweaver opened issue borgmatic-collective/borgmatic#682

2023-04-20 00:10:16 +00:00

[Bug] source_directories_must_exist does not expand globs and tildes

holocronweaver created repository holocronweaver/borgmatic

2023-04-20 00:09:34 +00:00