frequency can cause an invalid set of options
No need to apologise, it's a breakage of my own making since I probably didn't bother reading the release notes last time I upgraded :)
It's just an unfortunate one because the config being…
457ed80744
Fix environment variable plumbing so options in one configuration file aren't used for others (#555).
I've squashed everything down to a single commit instead of my chopping and hacking around, 100% code coverage, black, isort and flake8 are all happy so I think this is ready for reviewing…
3561c93d74
Fix Healthchecks tests that leak global state, breaking downstream tests (discovered in #543).
It is an enum, but my understanding (which appears to be backed up by my testing) is that when it's retrieved, because the enum is capitalised on the left hand side the .name is uppercase,…
Sorry you had to discover this the hard way.
💩 happens! Sounds like it was an experience for both of us.
That does make a ton of sense, because when I ran just my ntfy test to…
3561c93d74
Fix Healthchecks tests that leak global state, breaking downstream tests (discovered in #543).
I think one of the auto-formatters may have done this, as I don't remember doing it for these simple single-element dicts.
I'll clean it up and see if it comes back when black or flake8…
Yeah, I actually wasn't aware of the f-string until I was poking around in other modules to try and work out that test issue, but I do find that cleaner to read so I think I'll refactor to use those.
So I realised I was missing one last test to get 100% code coverage, which is the "connection error" test. I stole the one from one of the other tests as this seemed a relatively simple one, but…
Too much multi-tasking with my day job and a couple of force-pushed later, and this should be reviewable...the tests don't exhaustively cover every possible scenario but they do cover:
-…
This is not really necessary, but had to be done to keep flake8 happy because otherwise borgmatic.hooks.monitor was imported due to being required by the tests, even though it was not referenced within this hook directly.