borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
14
58
Fork 41
Code Issues 55 Pull Requests 2 Actions Packages Releases 122 Activity

Rework logging/verbosity system #90

Merged
witten merged 12 commits from :master into master 2018-09-08 20:53:38 +00:00
Conversation 7 Commits 12 Files Changed 16 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 53bd9b1300 - Show all commits

2
borgmatic/verbosity.py
View File

@ -12,4 +12,4 @@ def verbosity_to_log_level(verbosity):
return {
VERBOSITY_SOME: logging.INFO,
VERBOSITY_LOTS: logging.DEBUG,
}.get(verbosity, logging.WARNING)
}.get(verbosity, logging.INFO)
witten commented 2018-09-01 22:10:26 +00:00
Outdated
Review
Copy Link

The unknown verbosity is mapped to INFO. It was WARNING before, but think it’s more on the safe side. If confused, better print too much logging than too little.

Does this mean that if you omit -v/--verbosity from the borgmatic command-line, you'll know get INFO logs instead of WARNING? So now you'll get a fair amount of log spew whereas before it was pretty silent. That seems a little unexpected unless -v/--verbosity is specified. What's your thinking there?

> The unknown verbosity is mapped to INFO. It was WARNING before, but think it’s more on the safe side. If confused, better print too much logging than too little. Does this mean that if you omit `-v`/`--verbosity` from the borgmatic command-line, you'll know get `INFO` logs instead of `WARNING`? So now you'll get a fair amount of log spew whereas before it was pretty silent. That seems a little unexpected unless `-v`/`--verbosity` is specified. What's your thinking there?