borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
14
58
Fork 41
Code Issues 55 Pull Requests 2 Actions Packages Releases 122 Activity

[Documentation] Add compression level explanation and example #859

Merged
witten merged 2 commits from codimp/borgmatic:documentation-compression-level into main 2024-04-28 16:50:09 +00:00
Conversation 1 Commits 2 Files Changed 1 +2 -1
codimp commented 2024-04-28 16:23:43 +00:00
Contributor
Copy Link

Goal

Make compression level explicit in configuration comment.

Also add and example with zstd,7.

# Goal Make compression level explicit in configuration comment. Also add and example with `zstd,7`.
codimp added 1 commit 2024-04-28 16:23:43 +00:00
codimp force-pushed documentation-compression-level from e42fb97ee8 to eb1fce3787 2024-04-28 16:24:31 +00:00 Compare
witten reviewed 2024-04-28 16:33:45 +00:00
witten left a comment
Owner
Copy Link

Thank you for fixing this and submitting the PR!

Thank you for fixing this and submitting the PR!
borgmatic/config/schema.yaml Outdated
@ -270,3 +270,3 @@
type: string
description: |
Type of compression to use when creating archives. See
Type of compression to use when creating archives (compression
witten commented 2024-04-28 16:33:27 +00:00
Owner
Copy Link

Super minor nit: Would you mind making the parenthetical its own sentence? E.g. "Type of compression to use when creating archives. (Compression level can be blah blah blah.)"

Super minor nit: Would you mind making the parenthetical its own sentence? E.g. "Type of compression to use when creating archives. (Compression level can be blah blah blah.)"
codimp commented 2024-04-28 16:41:35 +00:00
Author
Contributor
Copy Link

Of course!

Of course!
codimp marked this conversation as resolved
codimp added 1 commit 2024-04-28 16:41:42 +00:00
witten merged commit 4f83b1e6b3 into main 2024-04-28 16:50:09 +00:00
witten commented 2024-04-28 16:50:18 +00:00
Owner
Copy Link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#859
No description provided.
Delete Branch "codimp/borgmatic:documentation-compression-level"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?