Fix "TypeError: 'module' object is not callable" in test_commands.py #676
No reviewers
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#676
Loading…
Reference in New Issue
No description provided.
Delete Branch ":import-flexmock-function"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Thanks for catching this. Your fix is clearly more correct than the existing code. But what baffles me is that I wasn't getting any test errors before this change. Were you? Do you have any idea what was going on?
Haven't tried with tox. I use the following to run the tests:
82f2867fd6/trunk/PKGBUILD (L38-L44)
(
-c /dev/null
is to avoid having to pull in thepython-coverage
package.)I do not.
Got it, thanks. I did confirm that the tests in question were running even before your change. And I noticed this from the
flexmock
docs:So maybe you just had an older version. Although following the
python-flexmock
link from the borgmatic Arch page shows a newer version. So, 🤷♂️.