borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
14
58
Fork 42
Code Issues 59 Pull Requests 3 Actions Packages Releases 122 Activity

WIP: Separate endpoint for each primary action for monitor hooks #660

Closed
jetchirag wants to merge 8 commits from jetchirag/borgmatic:action-based-monitor-endpoints into main
pull from: jetchirag/borgmatic:action-based-monitor-endpoints
merge into: borgmatic-collective:main
Conversation 9 Commits 8 Files Changed 15 +2 -1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2d728d57d7 - Show all commits

3
borgmatic/hooks/cronitor.py
View File

@ -35,8 +35,9 @@ def ping_monitor(hook_config, config_filename, state, monitoring_log_level, dry_
dry_run_label = ' (dry run; not actually pinging)' if dry_run else ''
try:
ping_url = f"{hook_config[action_name]}/{MONITOR_STATE_TO_CRONITOR[state]}"
ping_url = f"{hook_config['sss']}/{MONITOR_STATE_TO_CRONITOR[state]}"
except KeyError:
jetchirag marked this conversation as resolved
witten commented 2023-03-26 21:10:55 +00:00
Review
Copy Link

Nice, succinct way to skip unconfigured actions. You could optionally logger.debug() in the except so that it's clear what's being skipped and why.

Nice, succinct way to skip unconfigured actions. You could optionally `logger.debug()` in the `except` so that it's clear what's being skipped and why.
logger.debug(f'{config_filename}: Skipping Cronitor {state.name.lower()} ping due to unconfigured action: {action_name}')
jetchirag marked this conversation as resolved Outdated
diivi commented 2023-03-25 14:01:28 +00:00
Outdated
Review
Copy Link

Missed a debug log here 😄

Missed a debug log here 😄
jetchirag commented 2023-03-25 14:23:37 +00:00
Outdated
Review
Copy Link

Thanks! :)

Thanks! :)
return
logger.info(f'{config_filename}: Pinging Cronitor {state.name.lower()}{dry_run_label}')