borgmatic-collective/borgmatic
borgmatic-collective/borgmatic
9
74
Fork 56
Code Issues 58 Pull requests 5 Releases 161 Packages 1 Activity Actions 1

add option to set borg_files_cache_ttl in config #654

Merged
witten merged 2 commits from :feat618-allow-setting-borg-files-cache-ttl into master 2023-03-18 02:24:42 +00:00
Conversation 2 Commits 2 Files changed 3 +13 -1
Soumik_Dutta commented 2023-03-17 20:20:23 +00:00
Contributor
Copy link

Implements #618

Notes about about the str cast

Setting integer variables are not allowed and setting them as such will raise Exceptions in python os package,

TypeError: expected str, bytes or os.PathLike object, not int

So I had to add a str cast to the value.

Signed-off-by: Soumik Dutta shalearkane@gmail.com

Implements [#618](https://projects.torsion.org/borgmatic-collective/borgmatic/issues/618) ###### Notes about about the `str` cast Setting integer variables are not allowed and setting them as such will raise Exceptions in python `os` package, ```python TypeError: expected str, bytes or os.PathLike object, not int ``` So I had to add a `str` cast to the `value`. Signed-off-by: Soumik Dutta <shalearkane@gmail.com>
Signed-off-by: Soumik Dutta <shalearkane@gmail.com>
witten reviewed 2023-03-17 20:26:37 +00:00
witten left a comment
Copy link

This looks great! I'm happy to merge whenever you are ready.

This looks great! I'm happy to merge whenever you are ready.
borgmatic/borg/environment.py
@ -28,3 +29,3 @@
if value:
environment[environment_variable_name] = value
environment[environment_variable_name] = str(value)
witten commented 2023-03-17 20:26:13 +00:00
Owner
Copy link

You might consider adding a test for the fact that this converts integer values to strings in tests/unit/borg/test_environment.py. I certainly don't feel strongly about it though.

You might consider adding a test for the fact that this converts integer values to strings in `tests/unit/borg/test_environment.py`. I certainly don't feel strongly about it though.
borgmatic/config/schema.yaml
@ -318,0 +318,4 @@
borg_files_cache_ttl:
type: integer
description: |
Maximum time to live (ttl) for entries in the borg files
witten commented 2023-03-17 20:25:30 +00:00
Owner
Copy link

Minor nit: Capitalize "Borg" here.

Minor nit: Capitalize "Borg" here.
before setting them up to be environment variable values

Signed-off-by: Soumik Dutta <shalearkane@gmail.com>
Soumik_Dutta changed title from WIP: add option to set borg_files_cache_ttl in config to add option to set borg_files_cache_ttl in config 2023-03-18 00:03:57 +00:00
witten commented 2023-03-18 02:24:09 +00:00
Owner
Copy link

Thank you!

Thank you!
witten merged commit 214ae81cbb into master 2023-03-18 02:24:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

   
breaking

   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
borgmatic-collective/borgmatic!654
No description provided.