add option to set borg_files_cache_ttl in config #654
No reviewers
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#654
Loading…
Reference in New Issue
No description provided.
Delete Branch "Soumik_Dutta/borgmatic:feat618-allow-setting-borg-files-cache-ttl"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Implements #618
Notes about about the
str
castSetting integer variables are not allowed and setting them as such will raise Exceptions in python
os
package,So I had to add a
str
cast to thevalue
.Signed-off-by: Soumik Dutta shalearkane@gmail.com
This looks great! I'm happy to merge whenever you are ready.
@ -28,3 +29,3 @@
if value:
environment[environment_variable_name] = value
environment[environment_variable_name] = str(value)
You might consider adding a test for the fact that this converts integer values to strings in
tests/unit/borg/test_environment.py
. I certainly don't feel strongly about it though.@ -318,0 +318,4 @@
borg_files_cache_ttl:
type: integer
description: |
Maximum time to live (ttl) for entries in the borg files
Minor nit: Capitalize "Borg" here.
WIP: add option to set borg_files_cache_ttl in configto add option to set borg_files_cache_ttl in configThank you!