borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 53 Pull Requests 1 Actions Packages Releases 121 Activity

Add explicit requirement for jsonschema >= v3.0.0 #443

Closed
scratchcat1 wants to merge 1 commits from scratchcat1/borgmatic:fix/require-jsonschema-v3 into main
pull from: scratchcat1/borgmatic:fix/require-jsonschema-v3
merge into: borgmatic-collective:main
Conversation 2 Commits 1 Files Changed 1 +1 -1
scratchcat1 commented 2021-08-22 13:41:56 +00:00
First-time contributor
Copy Link

Borgmatic uses Draft7 from json schema which only was added in 3.0.0.
Upgrading on a machine which already had jsonschema v2 installed lead to errors regarding missing Draft7.

Borgmatic uses Draft7 from json schema which only was added in 3.0.0. Upgrading on a machine which already had jsonschema v2 installed lead to errors regarding missing Draft7.
scratchcat1 added 1 commit 2021-08-22 13:41:57 +00:00
88271b844e Add explicit requirement for jsonschema >= v3.0.0 
Borgmatic uses Draft7 from json schema which only was added in 3.0.0.
kimheino commented 2021-10-23 12:12:32 +00:00
Contributor
Copy Link

See PR #459 how both jsonschema v2 and v3 can be supported.

See PR #459 how both jsonschema v2 and v3 can be supported.
witten commented 2021-10-23 16:51:34 +00:00
Owner
Copy Link

Instead of this, I opted to merge the PR to add support for jsonschema v2: #459.

However, thank you for taking the time to submit your PR!

Instead of this, I opted to merge the PR to add support for jsonschema v2: #459. However, thank you for taking the time to submit your PR!
witten closed this pull request 2021-10-23 16:51:34 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#443
No description provided.
Delete Branch "scratchcat1/borgmatic:fix/require-jsonschema-v3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?