borgmatic-collective/borgmatic
borgmatic-collective/borgmatic
9
74
Fork 55
Code Issues 55 Pull requests 4 Releases 160 Packages 1 Activity Actions 1

Remove all configuration from Tox file #165

Merged
witten merged 2 commits from :cifix/tox-remove-config into master 2019-05-14 16:45:24 +00:00
Conversation 9 Commits 2 Files changed 3 +17 -8
decentral1se commented 2019-05-13 11:55:46 +00:00
Contributor
Copy link

This puts tool configuration in their familiar and standard locations and simplifies the Tox configuration to just laying out the environments and factors.

This also allows users who do not want to deal with overhead of Tox (for whatever reasons ...) to run pytest/black/etc. and have the same behaviour.

This puts tool configuration in their familiar and standard locations and simplifies the Tox configuration to just laying out the environments and factors. This also allows users who do not want to deal with overhead of Tox (for whatever reasons ...) to run pytest/black/etc. and have the same behaviour.
decentral1se commented 2019-05-13 11:57:10 +00:00
Author
Contributor
Copy link

Opened up witten/borgmatic#166 for a discussion on "officially" supporting more versions.

Opened up https://projects.torsion.org/witten/borgmatic/issues/166 for a discussion on "officially" supporting more versions.
decentral1se commented 2019-05-13 21:10:49 +00:00
Author
Contributor
Copy link

CI failure is quite an annoying ...

Obtaining file:///drone/src/projects.torsion.org/witten/borgmatic
ERROR: Error installing 'file:///drone/src/projects.torsion.org/witten/borgmatic': editable mode is not supported for pyproject.toml-style projects. pip is processing this project as pyproject.toml-style because it has a pyproject.toml file. Since the project has a setup.py and the pyproject.toml has no "build-backend" key for the "build_system" value, you may pass --no-use-pep517 to opt out of pyproject.toml-style processing. See PEP 517 for details on pyproject.toml-style projects.

See https://github.com/pypa/pip/issues/6434.

I'll add the recommended work-around.

CI failure is quite an annoying ... > Obtaining file:///drone/src/projects.torsion.org/witten/borgmatic ERROR: Error installing 'file:///drone/src/projects.torsion.org/witten/borgmatic': editable mode is not supported for pyproject.toml-style projects. pip is processing this project as pyproject.toml-style because it has a pyproject.toml file. Since the project has a setup.py and the pyproject.toml has no "build-backend" key for the "build_system" value, you may pass --no-use-pep517 to opt out of pyproject.toml-style processing. See PEP 517 for details on pyproject.toml-style projects. See https://github.com/pypa/pip/issues/6434. I'll add the recommended work-around.
witten reviewed 2019-05-13 23:56:49 +00:00
pyproject.toml
@ -0,0 +1,4 @@
[tool.black]
line-length = 100
target-version = ['py37']
witten commented 2019-05-13 23:52:03 +00:00
Owner
Copy link

Doesn't that mean the output formatted files will only support Python 3.7? I think the default behavior when this option is omitted is probably fine. From the black docs: "default: per-file auto-detection". Alternatively, if that's not good enough, 'py35' probably works as a target version here.

Doesn't that mean the output formatted files will only support Python 3.7? I think the default behavior when this option is omitted is probably fine. From the [black docs](https://github.com/python/black#command-line-options): "default: per-file auto-detection". Alternatively, if that's not good enough, 'py35' probably works as a target version here.
pyproject.toml
@ -0,0 +1,4 @@
[tool.black]
line-length = 100
target-version = ['py37']
skip-string-normalization = true
witten commented 2019-05-13 23:54:16 +00:00
Owner
Copy link

What on Earth is a pyproject.toml file? Seems like I'm not the first person to ask that question.

What on Earth is a `pyproject.toml` file? [Seems like I'm not the first person to ask that question.](https://github.com/python/black#what-on-earth-is-a-pyprojecttoml-file)
decentral1se commented 2019-05-14 11:16:37 +00:00
Author
Contributor
Copy link

hehe ... "the future" apparently ...

hehe ... "the future" apparently ...
witten commented 2019-05-13 23:57:29 +00:00
Owner
Copy link

Thank you so much for doing this! Looks like a good improvement.

Thank you so much for doing this! Looks like a good improvement.
decentral1se commented 2019-05-14 11:18:35 +00:00
Author
Contributor
Copy link

Cool! Comments addressed 👍

Cool! Comments addressed :thumbsup:
witten closed this pull request 2019-05-14 16:45:24 +00:00
decentral1se deleted branch cifix/tox-remove-config 2019-05-14 16:57:43 +00:00
witten commented 2019-05-14 17:06:59 +00:00
Owner
Copy link

See https://github.com/pypa/pip/issues/6434.

I’ll add the recommended work-around.

Looks like the work-around doesn't work on older versions of pip:

$ pip --version
pip 19.0.3 from /usr/lib/python3.7/site-packages/pip (python 3.7)
$ tox -r
py3 create: /home/witten/code/borgmatic/.tox/py3
py3 installdeps: -rtest_requirements.txt
ERROR: invocation failed (exit code 2), logfile: /home/witten/code/borgmatic/.tox/py3/log/py3-1.log
=================================================================== log start ====================================================================

Usage:   
  /home/witten/code/borgmatic/.tox/py3/bin/python -m pip install [options] <requirement specifier> [package-index-options] ...
  /home/witten/code/borgmatic/.tox/py3/bin/python -m pip install [options] -r <requirements file> [package-index-options] ...
  /home/witten/code/borgmatic/.tox/py3/bin/python -m pip install [options] [-e] <vcs project url> ...
  /home/witten/code/borgmatic/.tox/py3/bin/python -m pip install [options] [-e] <local project path> ...
  /home/witten/code/borgmatic/.tox/py3/bin/python -m pip install [options] <archive url/path> ...

no such option: --no-use-pep517
...
> See https://github.com/pypa/pip/issues/6434. > I’ll add the recommended work-around. Looks like the work-around doesn't work on older versions of pip: ``` $ pip --version pip 19.0.3 from /usr/lib/python3.7/site-packages/pip (python 3.7) $ tox -r py3 create: /home/witten/code/borgmatic/.tox/py3 py3 installdeps: -rtest_requirements.txt ERROR: invocation failed (exit code 2), logfile: /home/witten/code/borgmatic/.tox/py3/log/py3-1.log =================================================================== log start ==================================================================== Usage: /home/witten/code/borgmatic/.tox/py3/bin/python -m pip install [options] <requirement specifier> [package-index-options] ... /home/witten/code/borgmatic/.tox/py3/bin/python -m pip install [options] -r <requirements file> [package-index-options] ... /home/witten/code/borgmatic/.tox/py3/bin/python -m pip install [options] [-e] <vcs project url> ... /home/witten/code/borgmatic/.tox/py3/bin/python -m pip install [options] [-e] <local project path> ... /home/witten/code/borgmatic/.tox/py3/bin/python -m pip install [options] <archive url/path> ... no such option: --no-use-pep517 ... ```
decentral1se commented 2019-05-14 17:13:03 +00:00
Author
Contributor
Copy link

Hmmmm ... some notes in https://pypi.org/project/tox-pip-version/.

Do you expose VIRTUALENV_NO_DOWNLOAD=1? It should get the latest ...

Hmmmm ... some notes in https://pypi.org/project/tox-pip-version/. Do you expose `VIRTUALENV_NO_DOWNLOAD=1`? It should get the latest ...
witten commented 2019-05-14 17:22:19 +00:00
Owner
Copy link

Not using VIRTUALENV_NO_DOWNLOAD. I thought any given virtualenv pins a particular version of pip?

Not using `VIRTUALENV_NO_DOWNLOAD`. I thought any given virtualenv pins a particular version of pip?
witten commented 2019-05-14 17:31:52 +00:00
Owner
Copy link

Well, it's not pretty, but this appears to work: witten/borgmatic#175

Well, it's not pretty, but this appears to work: https://projects.torsion.org/witten/borgmatic/pulls/175
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

   
breaking

   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
borgmatic-collective/borgmatic!165
No description provided.