borgmatic-collective/borgmatic
11
70
Fork 40
Code Issues 49 Pull Requests 7 Actions 1 Packages Releases 152 Activity

Fix Python 3.14 incompatibility #1161

Merged
witten merged 1 commits from carmenbianca/borgmatic:fix-mode into main 2025-10-09 21:33:26 +00:00
Conversation 3 Commits 1 Files Changed 1 +1 -1
carmenbianca commented 2025-10-09 20:11:07 +00:00
Contributor
Copy Link

'mode' is not a valid argument to (Pure)Path. Passing keyword arguments is
deprecated since Python 3.12. I don't suspect it ever did anything. It is
removed in Python 3.14.

Without this patch, borgmatic crashes on Python 3.14.

This code was first introduced in e76bfa555f.

'mode' is not a valid argument to (Pure)Path. Passing keyword arguments is deprecated since Python 3.12. I don't suspect it ever did anything. It is removed in Python 3.14. Without this patch, borgmatic crashes on Python 3.14. This code was first introduced in e76bfa555fbab360a512c378e185707037d912ce.
carmenbianca added 1 commit 2025-10-09 20:11:07 +00:00
Remove non-existent argument to Path
All checks were successful
build / test (pull_request) Successful in 12m39s
Details
build / docs (pull_request) Has been skipped
Details
2b34c62e6f 
'mode' is not a valid argument to (Pure)Path. Passing keyword arguments is
deprecated since Python 3.12. I don't suspect it ever did anything. It is
removed in Python 3.14.

Without this patch, borgmatic crashes on Python 3.14.

This code was first introduced in e76bfa555f.
carmenbianca commented 2025-10-09 20:18:45 +00:00
Author
Contributor
Copy Link

I have not manually tested this patch.

I have not manually tested this patch.
witten commented 2025-10-09 21:33:10 +00:00
Owner
Copy Link

Thanks for fixing this! I was able to manually test it.

Thanks for fixing this! I was able to manually test it.
witten merged commit d15bed5d4f into main 2025-10-09 21:33:26 +00:00
witten commented 2025-10-24 04:52:11 +00:00
Owner
Copy Link

Released in borgmatic 2.0.10!

Released in borgmatic 2.0.10!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
witten
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#1161
Delete Branch "carmenbianca/borgmatic:fix-mode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?