borgmatic-collective/borgmatic
9
71
Fork 44
Code Issues 56 Pull Requests 6 Actions 1 Packages Releases 154 Activity

WIP: Custom command options for MongoDB hook #837 #1029

Closed
gautamaggarwal2810 wants to merge 2 commits from (deleted):modified_branch into main
pull from: (deleted):modified_branch
merge into: borgmatic-collective:main
Conversation 3 Commits 2 Files Changed 3 +168 -29
gautamaggarwal2810 commented 2025-03-17 07:35:49 +00:00
Contributor
Copy Link

Fixes #837.Will add unit tests soon.

Fixes #837.Will add unit tests soon.
gautamaggarwal2810 added 1 commit 2025-03-17 07:35:50 +00:00
Custom command options for MongoDB hook #837 3521a18a75
witten reviewed 2025-03-17 17:48:48 +00:00
witten left a comment
Owner
Copy Link

Looking good!

Looking good!
borgmatic/hooks/data_source/mongodb.py Outdated
@@ -131,0 +131,4 @@
dump_command = tuple(
shlex.quote(part)
for part in shlex.split(database.get('mongodump_command') or 'mongodump')
)
witten commented 2025-03-17 17:48:30 +00:00
Owner
Copy Link

This'll happen as part of running tests, but make sure to look at any black code formatting errors that you get. And tox -e black can do the reformatting for you.

This'll happen as part of running tests, but make sure to look at any `black` code formatting errors that you get. And `tox -e black` can do the reformatting for you.
gautamaggarwal2810 added 1 commit 2025-03-19 08:14:42 +00:00
Added unit tests f4b584c381
gautamaggarwal2810 force-pushed modified_branch from f4b584c381 to 33dd66e3e1 2025-03-19 08:21:37 +00:00 Compare
gautamaggarwal2810 commented 2025-03-19 08:23:52 +00:00
Author
Contributor
Copy Link

Added unit tests.All of them were successful.Please review and suggest any changes to be made.

Added unit tests.All of them were successful.Please review and suggest any changes to be made.
witten reviewed 2025-03-19 17:29:22 +00:00
borgmatic/hooks/data_source/mongodb.py
@@ -15,0 +20,4 @@
if value is None:
return value
# Remove dangerous characters and sequences
return re.sub(r'[;&|><]', '', value).strip()
witten commented 2025-03-19 17:26:09 +00:00
Owner
Copy Link

Why is this necessary if you're using shlex.quote()? And by removing characters outright instead of quoting them, won't this break some legitimate use cases? For instance, I think this approach would break many legitimate passwords that contain special characters.

Why is this necessary if you're using `shlex.quote()`? And by removing characters outright instead of quoting them, won't this break some legitimate use cases? For instance, I think this approach would break many legitimate passwords that contain special characters.
gautamaggarwal2810 commented 2025-03-20 03:42:24 +00:00
Author
Contributor
Copy Link

I used this because unit tests were failing without running this.I will try once more without using this function though.

I used this because unit tests were failing without running this.I will try once more without using this function though.
witten commented 2025-03-20 04:41:37 +00:00
Owner
Copy Link

I'm not sure why they'd fail, but I'd be happy to help with test failures if I can.

I'm not sure why they'd fail, but I'd be happy to help with test failures if I can.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
witten
Labels
Clear labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
witten
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#1029
Delete Branch "(deleted):modified_branch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?