borgmatic-collective/borgmatic
10
71
Fork 42
Code Issues 49 Pull Requests 6 Actions 1 Packages Releases 153 Activity

Add to argument exclusions for dry-run #1000

Closed
sean-wallace wants to merge 1 commits from sean-wallace/borgmatic:fix-filter-bug into main
pull from: sean-wallace/borgmatic:fix-filter-bug
merge into: borgmatic-collective:main
Conversation 3 Commits 1 Files Changed 1 +5 -2
sean-wallace commented 2025-02-17 22:31:05 +00:00
First-time contributor
Copy Link

Fixes #999

Fixes #999
sean-wallace added 1 commit 2025-02-17 22:31:05 +00:00
Add to argument exclusions for dry-run 3e1052c6e4
sean-wallace requested review from witten 2025-02-17 22:31:25 +00:00
witten commented 2025-02-17 23:39:45 +00:00
Owner
Copy Link

Thanks for taking the time to submit a PR for this! Here's a potential edge case though that makes borgmatic's simple approach to Borg flag exclusion not work here: --filter AME (as opposed to --filter=AME) is valid for Borg—and in fact is the documented way to pass flags with values. It looks like Borg does still accepts --filter=AME, but there's not guarantee a user will include that equals sign. So unfortunately I think any attempt to exclude this flag will have to be a bit smarter and, worst case, will even need to use something like argparse.

Thanks for taking the time to submit a PR for this! Here's a potential edge case though that makes borgmatic's simple approach to Borg flag exclusion not work here: `--filter AME` (as opposed to `--filter=AME`) is valid for Borg—and in fact is the documented way to pass flags with values. It looks like Borg does still accepts `--filter=AME`, but there's not guarantee a user will include that equals sign. So unfortunately I think any attempt to exclude this flag will have to be a bit smarter and, worst case, will even need to use something like `argparse`.
sean-wallace commented 2025-02-18 02:59:16 +00:00
Author
First-time contributor
Copy Link

Ah, that's a good point! Yes, it's definitely a bit more complicated than this simple approach. I may come back and make an attempt with argparse later, but mostly I think I'll just live with the limitation for the time being. Thanks again.

Ah, that's a good point! Yes, it's definitely a bit more complicated than this simple approach. I may come back and make an attempt with argparse later, but mostly I think I'll just live with the limitation for the time being. Thanks again.
witten commented 2025-02-22 06:39:42 +00:00
Owner
Copy Link

Okay, I'll close this PR for now and one of us will hopefully give it another go. 😄

Okay, I'll close this PR for now and one of us will hopefully give it another go. 😄
witten closed this pull request 2025-02-22 06:39:45 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
witten
Labels
Clear labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
witten
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#1000
Delete Branch "sean-wallace/borgmatic:fix-filter-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?