Borgmatic prefixes --stats output with repository label #996
Labels
No labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No milestone
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
borgmatic-collective/borgmatic#996
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What I'm trying to do and why
The
borgmatic create --statscommand prints stats with a repository prefix when I configure `postgresql_databases'.Steps to reproduce
compose.yamlborgmatic/test1.yamlborgmatic/test2.yamldocker compose updocker exec -it borgmatic borgmatic -nc init -e repokey-blake2docker exec -it borgmatic borgmatic -nc create --statsActual behavior
borgmatic -nc create --statsoutputDebug log
Expected behavior
Borgmatic should print all stats either with or without a prefix.
Other notes / implementation ideas
Offtopic about gitea instance
I've noticed that this gitea instance is down from time to time.
I could offer some help with server maintenance.
borgmatic version
1.9.9
borgmatic installation method
container image from ghcr.io/borgmatic-collective/borgmatic
Borg version
1.4.0
Python version
3.12.9
Database version (if applicable)
17.2
Operating system and version
alpine:3.21
Thanks for reporting this! I've reproduced the issue with both 1.9.9 and 1.9.10.. It's odd that it only seems to happen when databases are enabled. I think the "correct" behavior would be not to prefix Borg's own output with the repository label prefix; that's intended just for borgmatic's own logs. I'll dig into this when I get a chance.
Turns out it was a simple oversight and a simple fix. The code path that executed Borg when no databases were enabled correctly suppressed the repository label log prefix, but the code path that executed Borg with databases enabled left the prefix in place. Now that's been rectified and will be part of the next release. Thanks again!
Released in borgmatic 1.9.11!