1.9.9 requires python 3.10 #989

New Issue

Closed

opened 2025-02-04 06:50:32 +00:00 by kimheino · 3 comments

kimheino commented 2025-02-04 06:50:32 +00:00

Contributor

Copy Link

What I'm trying to do and why

Borgmatic 1.9.9 requires python 3.10. RHEL9 / Centos9 / etc have only python 3.9. Borgmatic 1.9.8 was fine.

https://docs.python.org/3/library/logging.html#logging.Formatter
"Changed in version 3.10: Added the defaults parameter."

Steps to reproduce

(08:47) root@risa:~> borgmatic
Traceback (most recent call last):
File "/usr/bin/borgmatic", line 8, in
sys.exit(main())
File "/usr/lib/python3.9/site-packages/borgmatic/commands/borgmatic.py", line 922, in main
configure_logging(
File "/usr/lib/python3.9/site-packages/borgmatic/logger.py", line 297, in configure_logging
console_handler.setFormatter(Console_color_formatter())
File "/usr/lib/python3.9/site-packages/borgmatic/logger.py", line 108, in init
super(Console_color_formatter, self).init(
TypeError: init() got an unexpected keyword argument 'defaults'

Actual behavior

No response

Expected behavior

Borgmatic to still support RHEL9 / Python 3.9.

Other notes / implementation ideas

No response

borgmatic version

No response

borgmatic installation method

No response

Borg version

1.9..9

Python version

3.9

Database version (if applicable)

No response

Operating system and version

No response

### What I'm trying to do and why Borgmatic 1.9.9 requires python 3.10. RHEL9 / Centos9 / etc have only python 3.9. Borgmatic 1.9.8 was fine. https://docs.python.org/3/library/logging.html#logging.Formatter "Changed in version 3.10: Added the defaults parameter." ### Steps to reproduce (08:47) root@risa:~> borgmatic Traceback (most recent call last): File "/usr/bin/borgmatic", line 8, in <module> sys.exit(main()) File "/usr/lib/python3.9/site-packages/borgmatic/commands/borgmatic.py", line 922, in main configure_logging( File "/usr/lib/python3.9/site-packages/borgmatic/logger.py", line 297, in configure_logging console_handler.setFormatter(Console_color_formatter()) File "/usr/lib/python3.9/site-packages/borgmatic/logger.py", line 108, in __init__ super(Console_color_formatter, self).__init__( TypeError: __init__() got an unexpected keyword argument 'defaults' ### Actual behavior _No response_ ### Expected behavior Borgmatic to still support RHEL9 / Python 3.9. ### Other notes / implementation ideas _No response_ ### borgmatic version _No response_ ### borgmatic installation method _No response_ ### Borg version 1.9..9 ### Python version 3.9 ### Database version (if applicable) _No response_ ### Operating system and version _No response_

witten commented 2025-02-04 07:25:39 +00:00

Owner

Copy Link

Ugh, thanks for filing this and tracking down the cause. My bad for missing the prominent Changed in version 3.10 label in the Python docs. I'll have to come up with another way to accomplish the logging feature since Python 3.9 isn't fully end-of-lifed for another nine months.

Ugh, thanks for filing this and tracking down the cause. My bad for missing the prominent *Changed in version 3.10* label in the Python docs. I'll have to come up with another way to accomplish the logging feature since Python 3.9 isn't fully [end-of-lifed](https://endoflife.date/python) for another nine months.

witten added the

bug

label 2025-02-04 07:25:47 +00:00

witten referenced this issue from a commit 2025-02-04 19:54:11 +00:00

Fix the log message code to avoid using Python 3.10+ logging features (#989).

witten commented 2025-02-04 19:54:15 +00:00

Owner

Copy Link

Okay, this should be fixed in main and will be part of the next release. I ended up finding an alternate way to inject the logging prefix into the Python logging formatter without relying on Python 3.10+ features (which were introduced in #635).

Thanks again!

Okay, this should be fixed in main and will be part of the next release. I ended up finding an alternate way to inject the logging prefix into the Python logging formatter without relying on Python 3.10+ features (which were introduced in #635). Thanks again!

witten closed this issue 2025-02-04 19:54:15 +00:00

witten referenced this issue 2025-02-07 16:53:50 +00:00

Borgmatic stopped working on 1/5 hosts. #992

witten commented 2025-02-11 06:36:48 +00:00

Owner

Copy Link

Released in borgmatic 1.9.10!

Released in borgmatic 1.9.10!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label

bug

Milestone

No items

No Milestone

Assignees

Clear assignees

diivi import_bot witten

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#989

No description provided.