Can't run archives check when max_duration is set, even with --only archives #988

New Issue

Closed

opened 2025-02-04 06:42:18 +00:00 by qrhfz · 5 comments

qrhfz commented 2025-02-04 06:42:18 +00:00

Copy Link

What I'm trying to do and why

I have a quite big repo in an HDD. I set max duration to limit repository check duration so i can do hourly backup. But, i still want to do daily archives check.

Steps to reproduce

Given a repository at: /run/media/q/wd-blue-4tb/content

And a config file at ~/.config/borgmatic.d/999-reproduce-steps.yaml with the following content:

repositories:
    - path: /run/media/q/wd-blue-4tb/content

skip_actions:
  - create
  - prune
  - compact

checks:
    - name: repository
      max_duration: 10
    - name: archives
      frequency: 1 day

Run

borgmatic -v2  --only archives -c .config/borgmatic.d/999-reproduce-steps.yaml

Actual behavior

/home/q/.config/borgmatic.d/999-reproduce-steps.yaml: No commands to run for pre-everything hook
/home/q/.config/borgmatic.d/999-reproduce-steps.yaml: Skipping create/prune/compact actions due to configured skip_actions
BORG_RELOCATED_REPO_ACCESS_IS_OK=*** BORG_UNKNOWN_UNENCRYPTED_REPO_ACCESS_IS_OK=*** BORG_EXIT_CODES=*** borg --version --debug --show-rc
/home/q/.config/borgmatic.d/999-reproduce-steps.yaml: Borg 1.4.0
/run/media/q/wd-blue-4tb/content: Running actions for repository
/home/q/.config/borgmatic.d/999-reproduce-steps.yaml: No commands to run for pre-actions hook
/home/q/.config/borgmatic.d/999-reproduce-steps.yaml: No commands to run for pre-check hook
/run/media/q/wd-blue-4tb/content: Running consistency checks
BORG_RELOCATED_REPO_ACCESS_IS_OK=*** BORG_UNKNOWN_UNENCRYPTED_REPO_ACCESS_IS_OK=*** BORG_EXIT_CODES=*** borg info --json /run/media/q/wd-blue-4tb/content
Reading check time from /home/q/.local/state/borgmatic/checks/a3d3a526120721ffb75450a3e3e7718734369389d2605fd78814f145fa57b070/archives/5b39eb3d2ace2c2200255dd92f1565be627b366f3fa7f32ee9113f7fd548afc6
Reading check time from /home/q/.local/state/borgmatic/checks/a3d3a526120721ffb75450a3e3e7718734369389d2605fd78814f145fa57b070/archives/all
/run/media/q/wd-blue-4tb/content: Error running actions for repository
The archives check cannot run when the repository check has the max_duration option set
/home/q/.config/borgmatic.d/999-reproduce-steps.yaml: No commands to run for on-error hook
/home/q/.config/borgmatic.d/999-reproduce-steps.yaml: An error occurred
/home/q/.config/borgmatic.d/999-reproduce-steps.yaml: No commands to run for post-everything hook

summary:
/home/q/.config/borgmatic.d/999-reproduce-steps.yaml: Loading configuration file
/home/q/.config/borgmatic.d/999-reproduce-steps.yaml: An error occurred
/run/media/q/wd-blue-4tb/content: Error running actions for repository
The archives check cannot run when the repository check has the max_duration option set

Need some help? https://torsion.org/borgmatic/#issues

Expected behavior

Given that max_duration is only applicable to repository check. Borgmatic should ignore max_duration when '--only archives' is set. Even better if Borgmatic could be smart enough to sepearate repository check from other checks when max_duration is set.

Other notes / implementation ideas

No response

borgmatic version

1.9.8

borgmatic installation method

pipx

Borg version

borg 1.4.0

Python version

No response

Database version (if applicable)

Python 3.13.1

Operating system and version

Arch Linux

### What I'm trying to do and why I have a quite big repo in an HDD. I set max duration to limit repository check duration so i can do hourly backup. But, i still want to do daily archives check. ### Steps to reproduce Given a repository at: `/run/media/q/wd-blue-4tb/content` And a config file at `~/.config/borgmatic.d/999-reproduce-steps.yaml` with the following content: ``` repositories: - path: /run/media/q/wd-blue-4tb/content skip_actions: - create - prune - compact checks: - name: repository max_duration: 10 - name: archives frequency: 1 day ``` Run ``` borgmatic -v2 --only archives -c .config/borgmatic.d/999-reproduce-steps.yaml ``` ### Actual behavior ``` /home/q/.config/borgmatic.d/999-reproduce-steps.yaml: No commands to run for pre-everything hook /home/q/.config/borgmatic.d/999-reproduce-steps.yaml: Skipping create/prune/compact actions due to configured skip_actions BORG_RELOCATED_REPO_ACCESS_IS_OK=*** BORG_UNKNOWN_UNENCRYPTED_REPO_ACCESS_IS_OK=*** BORG_EXIT_CODES=*** borg --version --debug --show-rc /home/q/.config/borgmatic.d/999-reproduce-steps.yaml: Borg 1.4.0 /run/media/q/wd-blue-4tb/content: Running actions for repository /home/q/.config/borgmatic.d/999-reproduce-steps.yaml: No commands to run for pre-actions hook /home/q/.config/borgmatic.d/999-reproduce-steps.yaml: No commands to run for pre-check hook /run/media/q/wd-blue-4tb/content: Running consistency checks BORG_RELOCATED_REPO_ACCESS_IS_OK=*** BORG_UNKNOWN_UNENCRYPTED_REPO_ACCESS_IS_OK=*** BORG_EXIT_CODES=*** borg info --json /run/media/q/wd-blue-4tb/content Reading check time from /home/q/.local/state/borgmatic/checks/a3d3a526120721ffb75450a3e3e7718734369389d2605fd78814f145fa57b070/archives/5b39eb3d2ace2c2200255dd92f1565be627b366f3fa7f32ee9113f7fd548afc6 Reading check time from /home/q/.local/state/borgmatic/checks/a3d3a526120721ffb75450a3e3e7718734369389d2605fd78814f145fa57b070/archives/all /run/media/q/wd-blue-4tb/content: Error running actions for repository The archives check cannot run when the repository check has the max_duration option set /home/q/.config/borgmatic.d/999-reproduce-steps.yaml: No commands to run for on-error hook /home/q/.config/borgmatic.d/999-reproduce-steps.yaml: An error occurred /home/q/.config/borgmatic.d/999-reproduce-steps.yaml: No commands to run for post-everything hook summary: /home/q/.config/borgmatic.d/999-reproduce-steps.yaml: Loading configuration file /home/q/.config/borgmatic.d/999-reproduce-steps.yaml: An error occurred /run/media/q/wd-blue-4tb/content: Error running actions for repository The archives check cannot run when the repository check has the max_duration option set Need some help? https://torsion.org/borgmatic/#issues ``` ### Expected behavior Given that max_duration is only applicable to repository check. Borgmatic should ignore `max_duration` when '--only archives' is set. Even better if Borgmatic could be smart enough to sepearate repository check from other checks when `max_duration` is set. ### Other notes / implementation ideas _No response_ ### borgmatic version 1.9.8 ### borgmatic installation method pipx ### Borg version borg 1.4.0 ### Python version _No response_ ### Database version (if applicable) Python 3.13.1 ### Operating system and version Arch Linux

witten commented 2025-02-04 07:32:37 +00:00

Owner

Copy Link

Thanks for filing this! Seems reasonable to me.. (Either one of those approaches you described.)

Thanks for filing this! Seems reasonable to me.. (Either one of those approaches you described.)

witten referenced this issue from a commit 2025-02-06 19:52:35 +00:00

With the "max_duration" option or the "--max-duration" flag, run the archives and repository checks separately so they don't interfere with one another (#988).

witten commented 2025-02-06 19:54:43 +00:00

Owner

Copy Link

Okay, this is implemented in main and will be part of the next release! I went with your idea of making borgmatic smart enough to run archives and repository checks independently when a max duration is set (via option or CLI flag). Thanks again!

Okay, this is implemented in main and will be part of the next release! I went with your idea of making borgmatic smart enough to run archives and repository checks independently when a max duration is set (via option or CLI flag). Thanks again!

witten closed this issue 2025-02-06 19:54:43 +00:00

witten commented 2025-02-11 06:36:38 +00:00

Owner

Copy Link

Released in borgmatic 1.9.10!

Released in borgmatic 1.9.10!

qrhfz commented 2025-02-13 02:23:27 +00:00

Author

Copy Link

Released in borgmatic 1.9.10!

Thank you. It works perfectly.

> Released in borgmatic 1.9.10! Thank you. It works perfectly.

witten commented 2025-02-13 02:58:02 +00:00

Owner

Copy Link

Awesome, glad to hear it!

Awesome, glad to hear it!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

config-command-line

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

diivi import_bot witten

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#988

No description provided.