Borg patterns is broken #977

New Issue

Closed

opened 2025-01-23 16:49:12 +00:00 by pasha132 · 3 comments

pasha132 commented 2025-01-23 16:49:12 +00:00

Contributor

Copy Link

What I'm trying to do and why

Hello!

After update to 1.9.6 it is unable to use borg patterns. Whatever you write in appropriate sections will be prepended with 'fn' prefix.

Possible solution is in PR #976

Steps to reproduce

Write something like in config:

exclude_patterns:
    - 'sh:**/directory'

And execute borgmatic in dry-run, for example. You will see 'fn:sh:**/directory' in logs.

Actual behavior

No response

Expected behavior

Exact pattern templates should not be changed.

Other notes / implementation ideas

No response

borgmatic version

1.9.6

borgmatic installation method

Gentoo portage

Borg version

borg 1.4.0

Python version

Python 3.12.8

Database version (if applicable)

No response

Operating system and version

No response

### What I'm trying to do and why Hello! After update to 1.9.6 it is unable to use borg patterns. Whatever you write in appropriate sections will be prepended with 'fn' prefix. Possible solution is in PR #976 ### Steps to reproduce Write something like in config: ``` exclude_patterns: - 'sh:**/directory' ``` And execute borgmatic in dry-run, for example. You will see `'fn:sh:**/directory'` in logs. ### Actual behavior _No response_ ### Expected behavior Exact pattern templates should not be changed. ### Other notes / implementation ideas _No response_ ### borgmatic version 1.9.6 ### borgmatic installation method Gentoo portage ### Borg version borg 1.4.0 ### Python version Python 3.12.8 ### Database version (if applicable) _No response_ ### Operating system and version _No response_

witten commented 2025-01-23 18:35:31 +00:00

Owner

Copy Link

Thank you so much for finding and fixing this! I think I just totally spaced on the fact that exclude_patterns can actually be patterns and aren't just plain ol' paths. Anyway, my comments are on the PR.

Thank you so much for finding and fixing this! I think I just totally spaced on the fact that `exclude_patterns` can actually be patterns and aren't just plain ol' paths. Anyway, my comments are on the PR.

witten added the bug label 2025-01-23 18:35:36 +00:00

witten referenced this issue from a commit 2025-01-23 20:06:13 +00:00

Fix exclude patterns parsing to support pattern styles (#977).

witten commented 2025-01-23 20:06:40 +00:00

Owner

Copy Link

PR merged! I'll put out a release with this shortly.

PR merged! I'll put out a release with this shortly.

❤️ 1

witten closed this issue 2025-01-23 20:06:40 +00:00

witten referenced this issue from a commit 2025-01-23 20:13:59 +00:00

Add #977 to NEWS.

witten commented 2025-01-23 20:16:12 +00:00

Owner

Copy Link

Released in borgmatic 1.9.7!

Released in borgmatic 1.9.7!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

command-hook-steps

2.1.2

2.1.1

2.1.0

2.0.13

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label bug

Milestone

No items

No Milestone

Assignees

Clear assignees

witten

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#977