regression: An empty line in a patterns_from file causes error ('Invalid pattern:', '') #970

New Issue

Closed

opened 2025-01-18 14:19:54 +00:00 by jinnatar · 3 comments

jinnatar commented 2025-01-18 14:19:54 +00:00

Copy Link

What I'm trying to do and why

Run backups based on a separate patterns file injected with patterns_from. For clarity, separate "sections" in my pattern file have had an empty line between them. This empty line is now as of today interpreted as a pattern which causes borgmatic to exit with ('Invalid pattern:', '')

Steps to reproduce

Use a patterns.lst file such as:

- *.tmp
- *.pyc
! **/.cache/
! **/Cache/
! **/cache/
! **/.noindex
! **/__pycache__
! **/_cacache

R ./
! esphome/.esphome/build/
! esphome/.esphome/platformio/

Run it via a config containing:

patterns_from:
  - /local/patterns.lst

Actual behavior

summary:
/etc/borgmatic.d/borgmatic.yaml: An error occurred
localserver: Error running actions for repository
('Invalid pattern:', '')

Expected behavior

Ignore the empty pattern line as before.

Other notes / implementation ideas

Based on timing I'm betting this came with release 1.9.6.

borgmatic version

1.9.6

borgmatic installation method

ghcr.io/borgmatic-collective/borgmatic:latest

Borg version

N/A

Python version

N/A

Database version (if applicable)

N/A

Operating system and version

N/A

### What I'm trying to do and why Run backups based on a separate patterns file injected with `patterns_from`. For clarity, separate "sections" in my pattern file have had an empty line between them. This empty line is now as of today interpreted as a pattern which causes borgmatic to exit with `('Invalid pattern:', '')` ### Steps to reproduce Use a patterns.lst file such as: ``` - *.tmp - *.pyc ! **/.cache/ ! **/Cache/ ! **/cache/ ! **/.noindex ! **/__pycache__ ! **/_cacache R ./ ! esphome/.esphome/build/ ! esphome/.esphome/platformio/ ``` Run it via a config containing: ```yaml patterns_from: - /local/patterns.lst ``` ### Actual behavior > summary: /etc/borgmatic.d/borgmatic.yaml: An error occurred localserver: Error running actions for repository ('Invalid pattern:', '') ### Expected behavior Ignore the empty pattern line as before. ### Other notes / implementation ideas Based on timing I'm betting this came with release `1.9.6`. ### borgmatic version 1.9.6 ### borgmatic installation method ghcr.io/borgmatic-collective/borgmatic:latest ### Borg version N/A ### Python version N/A ### Database version (if applicable) N/A ### Operating system and version N/A

witten commented 2025-01-18 17:11:21 +00:00

Owner

Copy Link

Yeah, this is definitely a regression introduced by 1.9.6 and specifically by #962. Thanks for taking the time to file it! I can work on a fix, but in the meantime, you can either downgrade to borgmatic 1.9.5 or replace your blank lines with comments (just # by itself on a line would do it).

Yeah, this is definitely a regression introduced by 1.9.6 and specifically by #962. Thanks for taking the time to file it! I can work on a fix, but in the meantime, you can either downgrade to borgmatic 1.9.5 or replace your blank lines with comments (just `#` by itself on a line would do it).

witten referenced this issue from a commit 2025-01-18 17:25:45 +00:00

Fix for an error when a blank line occurs in the configured patterns or excludes (#970).

witten commented 2025-01-18 17:26:14 +00:00

Owner

Copy Link

This is fixed in main now and will be part of the next release. (For the record, the same problem also applied to excludes.) Thanks again!

This is fixed in main now and will be part of the next release. (For the record, the same problem also applied to excludes.) Thanks again!

witten closed this issue 2025-01-18 17:26:14 +00:00

iljur referenced this issue 2025-01-20 22:28:39 +00:00

exclude_patterns in config file also seem to be ignored since 1.9.6 #972

witten commented 2025-01-23 20:16:01 +00:00

Owner

Copy Link

Released in borgmatic 1.9.7!

Released in borgmatic 1.9.7!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

command-hook-steps

2.1.2

2.1.1

2.1.0

2.0.13

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

witten

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#970