borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
14
57
Fork 41
Code Issues 53 Pull Requests 2 Actions Packages Releases 122 Activity

Recent master fails test #95

New Issue
Closed
opened 2018-09-24 14:00:26 +00:00 by floli · 3 comments
floli commented 2018-09-24 14:00:26 +00:00
Collaborator
Copy Link

This is from 5d8ac158ce, Arch Linux, Python 3.7.0

py3 develop-inst-nodeps: /home/florian/software/borgmatic
WARNING: Discarding $PYTHONPATH from environment, to override specify PYTHONPATH in 'passenv' in your configuration.
py3 installed: atomicwrites==1.2.1,attrs==18.2.0,-e git+ssh://git@projects.torsion.org:3022/floli/borgmatic.git@5d8ac158ce90025fc9f19c6c2e19937dff1a2be8#egg=borgmatic,coverage==4.5.1,docopt==0.6.2,flexmock==0.10.2,more-itertools==4.3.0,pluggy==0.7.1,py==1.6.0,pykwalify==1.6.1,pytest==3.7.4,pytest-cov==2.5.1,python-dateutil==2.7.3,PyYAML==3.13,ruamel.yaml==0.15.70,six==1.11.0
py3 run-test-pre: PYTHONHASHSEED='108996576'
py3 runtests: commands[0] | py.test --cov-report term-missing:skip-covered --cov=borgmatic borgmatic
=========================================================================================================== test session starts ============================================================================================================
platform linux -- Python 3.7.0, pytest-3.7.4, py-1.6.0, pluggy-0.7.1
rootdir: /home/florian/software/borgmatic, inifile:
plugins: cov-2.5.1
collected 182 items                                                                                                                                                                                                                        

borgmatic/tests/integration/test_version.py .                                                                                                                                                                                        [  0%]
borgmatic/tests/integration/commands/test_borgmatic.py ............                                                                                                                                                                  [  7%]
borgmatic/tests/integration/commands/test_convert_config.py ....                                                                                                                                                                     [  9%]
borgmatic/tests/integration/commands/test_generate_config.py ..                                                                                                                                                                      [ 10%]
borgmatic/tests/integration/config/test_generate.py F...F.                                                                                                                                                                           [ 13%]
borgmatic/tests/integration/config/test_legacy.py .                                                                                                                                                                                  [ 14%]
borgmatic/tests/integration/config/test_validate.py ........                                                                                                                                                                         [ 18%]
borgmatic/tests/unit/test_verbosity.py ..                                                                                                                                                                                            [ 19%]
borgmatic/tests/unit/borg/test_check.py ..........................                                                                                                                                                                   [ 34%]
borgmatic/tests/unit/borg/test_create.py ...............................................                                                                                                                                             [ 59%]
borgmatic/tests/unit/borg/test_extract.py .......                                                                                                                                                                                    [ 63%]
borgmatic/tests/unit/borg/test_hook.py ...                                                                                                                                                                                           [ 65%]
borgmatic/tests/unit/borg/test_info.py .......                                                                                                                                                                                       [ 69%]
borgmatic/tests/unit/borg/test_list.py .......                                                                                                                                                                                       [ 73%]
borgmatic/tests/unit/borg/test_prune.py ..........                                                                                                                                                                                   [ 78%]
borgmatic/tests/unit/commands/test_borgmatic.py .                                                                                                                                                                                    [ 79%]
borgmatic/tests/unit/config/test_collect.py .........                                                                                                                                                                                [ 84%]
borgmatic/tests/unit/config/test_convert.py .........                                                                                                                                                                                [ 89%]
borgmatic/tests/unit/config/test_generate.py .                                                                                                                                                                                       [ 89%]
borgmatic/tests/unit/config/test_legacy.py .............                                                                                                                                                                             [ 96%]
borgmatic/tests/unit/config/test_validate.py ......                                                                                                                                                                                  [100%]

================================================================================================================= FAILURES =================================================================================================================
____________________________________________________________________________________________ test_insert_newline_before_comment_does_not_raise _____________________________________________________________________________________________

    def test_insert_newline_before_comment_does_not_raise():
        field_name = 'foo'
>       config = module.yaml.comments.CommentedMap([(field_name, 33)])

borgmatic/tests/integration/config/test_generate.py:13: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.tox/py3/lib/python3.7/site-packages/ruamel/yaml/comments.py:647: in __init__
    ordereddict.__init__(self, *args, **kw)  # type: ignore
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = ordereddict([('foo', 33)]), key = 'foo', value = 33

    def __setitem__(self, key, value):
        # type: (Any, Any) -> None
        # try to preserve the scalarstring type if setting an existing key to a new value
        if key in self:
            if (
                isinstance(value, string_types)
                and not isinstance(value, ScalarString)
                and isinstance(self[key], ScalarString)
            ):
                value = type(self[key])(value)
        ordereddict.__setitem__(self, key, value)
>       self._ok.add(key)
E       AttributeError: _ok

.tox/py3/lib/python3.7/site-packages/ruamel/yaml/comments.py:775: AttributeError
____________________________________________________________________________________________ test_add_comments_to_configuration_does_not_raise _____________________________________________________________________________________________

    def test_add_comments_to_configuration_does_not_raise():
        # Ensure that it can deal with fields both in the schema and missing from the schema.
>       config = module.yaml.comments.CommentedMap([('foo', 33), ('bar', 44), ('baz', 55)])

borgmatic/tests/integration/config/test_generate.py:48: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.tox/py3/lib/python3.7/site-packages/ruamel/yaml/comments.py:647: in __init__
    ordereddict.__init__(self, *args, **kw)  # type: ignore
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = ordereddict([('foo', 33)]), key = 'foo', value = 33

    def __setitem__(self, key, value):
        # type: (Any, Any) -> None
        # try to preserve the scalarstring type if setting an existing key to a new value
        if key in self:
            if (
                isinstance(value, string_types)
                and not isinstance(value, ScalarString)
                and isinstance(self[key], ScalarString)
            ):
                value = type(self[key])(value)
        ordereddict.__setitem__(self, key, value)
>       self._ok.add(key)
E       AttributeError: _ok

.tox/py3/lib/python3.7/site-packages/ruamel/yaml/comments.py:775: AttributeError

----------- coverage: platform linux, python 3.7.0-final-0 -----------
Name                                                  Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------
borgmatic/config/generate.py                             36      4    89%   15, 76-82
borgmatic/tests/integration/config/test_generate.py      39      4    90%   14-16, 49-56
-----------------------------------------------------------------------------------
TOTAL                                                  1497      8    99%

48 files skipped due to complete coverage.

=================================================================================================== 2 failed, 180 passed in 1.31 seconds ===================================================================================================
ERROR: InvocationError for command '/home/florian/software/borgmatic/.tox/py3/bin/py.test --cov-report term-missing:skip-covered --cov=borgmatic borgmatic' (exited with code 1)
_________________________________________________________________________________________________________________ summary __________________________________________________________________________________________________________________
ERROR:   py3: commands failed
This is from 5d8ac158ce90025fc9f19c6c2e19937dff1a2be8, Arch Linux, Python 3.7.0 ``` py3 develop-inst-nodeps: /home/florian/software/borgmatic WARNING: Discarding $PYTHONPATH from environment, to override specify PYTHONPATH in 'passenv' in your configuration. py3 installed: atomicwrites==1.2.1,attrs==18.2.0,-e git+ssh://git@projects.torsion.org:3022/floli/borgmatic.git@5d8ac158ce90025fc9f19c6c2e19937dff1a2be8#egg=borgmatic,coverage==4.5.1,docopt==0.6.2,flexmock==0.10.2,more-itertools==4.3.0,pluggy==0.7.1,py==1.6.0,pykwalify==1.6.1,pytest==3.7.4,pytest-cov==2.5.1,python-dateutil==2.7.3,PyYAML==3.13,ruamel.yaml==0.15.70,six==1.11.0 py3 run-test-pre: PYTHONHASHSEED='108996576' py3 runtests: commands[0] | py.test --cov-report term-missing:skip-covered --cov=borgmatic borgmatic =========================================================================================================== test session starts ============================================================================================================ platform linux -- Python 3.7.0, pytest-3.7.4, py-1.6.0, pluggy-0.7.1 rootdir: /home/florian/software/borgmatic, inifile: plugins: cov-2.5.1 collected 182 items borgmatic/tests/integration/test_version.py . [ 0%] borgmatic/tests/integration/commands/test_borgmatic.py ............ [ 7%] borgmatic/tests/integration/commands/test_convert_config.py .... [ 9%] borgmatic/tests/integration/commands/test_generate_config.py .. [ 10%] borgmatic/tests/integration/config/test_generate.py F...F. [ 13%] borgmatic/tests/integration/config/test_legacy.py . [ 14%] borgmatic/tests/integration/config/test_validate.py ........ [ 18%] borgmatic/tests/unit/test_verbosity.py .. [ 19%] borgmatic/tests/unit/borg/test_check.py .......................... [ 34%] borgmatic/tests/unit/borg/test_create.py ............................................... [ 59%] borgmatic/tests/unit/borg/test_extract.py ....... [ 63%] borgmatic/tests/unit/borg/test_hook.py ... [ 65%] borgmatic/tests/unit/borg/test_info.py ....... [ 69%] borgmatic/tests/unit/borg/test_list.py ....... [ 73%] borgmatic/tests/unit/borg/test_prune.py .......... [ 78%] borgmatic/tests/unit/commands/test_borgmatic.py . [ 79%] borgmatic/tests/unit/config/test_collect.py ......... [ 84%] borgmatic/tests/unit/config/test_convert.py ......... [ 89%] borgmatic/tests/unit/config/test_generate.py . [ 89%] borgmatic/tests/unit/config/test_legacy.py ............. [ 96%] borgmatic/tests/unit/config/test_validate.py ...... [100%] ================================================================================================================= FAILURES ================================================================================================================= ____________________________________________________________________________________________ test_insert_newline_before_comment_does_not_raise _____________________________________________________________________________________________ def test_insert_newline_before_comment_does_not_raise(): field_name = 'foo' > config = module.yaml.comments.CommentedMap([(field_name, 33)]) borgmatic/tests/integration/config/test_generate.py:13: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ .tox/py3/lib/python3.7/site-packages/ruamel/yaml/comments.py:647: in __init__ ordereddict.__init__(self, *args, **kw) # type: ignore _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = ordereddict([('foo', 33)]), key = 'foo', value = 33 def __setitem__(self, key, value): # type: (Any, Any) -> None # try to preserve the scalarstring type if setting an existing key to a new value if key in self: if ( isinstance(value, string_types) and not isinstance(value, ScalarString) and isinstance(self[key], ScalarString) ): value = type(self[key])(value) ordereddict.__setitem__(self, key, value) > self._ok.add(key) E AttributeError: _ok .tox/py3/lib/python3.7/site-packages/ruamel/yaml/comments.py:775: AttributeError ____________________________________________________________________________________________ test_add_comments_to_configuration_does_not_raise _____________________________________________________________________________________________ def test_add_comments_to_configuration_does_not_raise(): # Ensure that it can deal with fields both in the schema and missing from the schema. > config = module.yaml.comments.CommentedMap([('foo', 33), ('bar', 44), ('baz', 55)]) borgmatic/tests/integration/config/test_generate.py:48: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ .tox/py3/lib/python3.7/site-packages/ruamel/yaml/comments.py:647: in __init__ ordereddict.__init__(self, *args, **kw) # type: ignore _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = ordereddict([('foo', 33)]), key = 'foo', value = 33 def __setitem__(self, key, value): # type: (Any, Any) -> None # try to preserve the scalarstring type if setting an existing key to a new value if key in self: if ( isinstance(value, string_types) and not isinstance(value, ScalarString) and isinstance(self[key], ScalarString) ): value = type(self[key])(value) ordereddict.__setitem__(self, key, value) > self._ok.add(key) E AttributeError: _ok .tox/py3/lib/python3.7/site-packages/ruamel/yaml/comments.py:775: AttributeError ----------- coverage: platform linux, python 3.7.0-final-0 ----------- Name Stmts Miss Cover Missing ----------------------------------------------------------------------------------- borgmatic/config/generate.py 36 4 89% 15, 76-82 borgmatic/tests/integration/config/test_generate.py 39 4 90% 14-16, 49-56 ----------------------------------------------------------------------------------- TOTAL 1497 8 99% 48 files skipped due to complete coverage. =================================================================================================== 2 failed, 180 passed in 1.31 seconds =================================================================================================== ERROR: InvocationError for command '/home/florian/software/borgmatic/.tox/py3/bin/py.test --cov-report term-missing:skip-covered --cov=borgmatic borgmatic' (exited with code 1) _________________________________________________________________________________________________________________ summary __________________________________________________________________________________________________________________ ERROR: py3: commands failed ```
witten commented 2018-09-24 15:09:49 +00:00
Owner
Copy Link

Thanks for reporting. My guess is that this is a newly introduced breakage/incompatibility with ruamel.yaml 0.15.70, just released.

Thanks for reporting. My guess is that this is a newly introduced breakage/incompatibility with [ruamel.yaml 0.15.70](https://pypi.org/project/ruamel.yaml/#changelog), just released.
witten added the
bug
 label 2018-09-24 15:11:18 +00:00
witten commented 2018-09-26 05:52:15 +00:00
Owner
Copy Link

I haven't come up with a fix, but I did file this ruamel.yaml ticket, so we'll see what happens with that: https://bitbucket.org/ruamel/yaml/issues/242/01570-breaks-commentedmap-constructor

The apparent regression appears to have been introduced by https://bitbucket.org/ruamel/yaml/issues/233/api-discussion-base-classes-of which was released as part of ruamel.yaml 0.15.70.

I haven't come up with a fix, but I did file this ruamel.yaml ticket, so we'll see what happens with that: https://bitbucket.org/ruamel/yaml/issues/242/01570-breaks-commentedmap-constructor The apparent regression appears to have been introduced by https://bitbucket.org/ruamel/yaml/issues/233/api-discussion-base-classes-of which was released as part of ruamel.yaml 0.15.70.
witten commented 2018-09-27 02:49:05 +00:00
Owner
Copy Link

ruamel.yaml 0.15.71 fixes the issue. I recommend you upgrade ruamel.yaml!

See https://bitbucket.org/ruamel/yaml/issues/242/01570-breaks-commentedmap-constructor for more info.

ruamel.yaml 0.15.71 fixes the issue. I recommend you upgrade ruamel.yaml! See https://bitbucket.org/ruamel/yaml/issues/242/01570-breaks-commentedmap-constructor for more info.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.11
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#95
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?