pyproject.yaml missing build-backend key causes Fedora buildsystem to call non-existent setup.py #932

New Issue

Closed

opened 2024-11-11 01:00:31 +00:00 by kaechele · 2 comments

kaechele commented 2024-11-11 01:00:31 +00:00

Contributor

Copy Link

What I'm trying to do and why

pyproject.yaml is missing the build-backend key. It's there, but commented out.

Fedora's buildsystem, in adherence with PEP 517, will then try to execute the non-existent setup.py.

Relevant PEP 517 quote:

If the pyproject.toml file is absent, or the build-backend key is missing, the source tree is not using this specification, and tools should revert to the legacy behaviour of running setup.py (either directly, or by implicitly invoking the setuptools.build_meta:legacy backend).

Steps to reproduce

Downloading the latest borgmatic RPM spec file and try building it locally or in mock.

Actual behavior

Snippet from Fedora buildsystem:

+ /usr/bin/python3 -Bs /usr/lib/rpm/redhat/pyproject_buildrequires.py --generate-extras --python3_pkgversion 3 --wheeldir /builddir/build/BUILD/borgmatic-1.9.1-build/pyproject-wheeldir --output /builddir/build/BUILD/borgmatic-1.9.1-build/borgmatic-1.9.1-2.fc42.x86_64-pyproject-buildrequires
Handling setuptools>=61.0 from build-system.requires
Requirement not satisfied: setuptools>=61.0
Traceback (most recent call last):
  File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 721, in main
    generate_requires(
    ~~~~~~~~~~~~~~~~~^
        include_runtime=args.runtime,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<11 lines>...
        config_settings=parse_config_settings_args(args.config_settings),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 602, in generate_requires
    backend = get_backend(requirements)
  File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 263, in get_backend
    raise FileNotFoundError('File "setup.py" not found for legacy project.')
FileNotFoundError: File "setup.py" not found for legacy project.

Expected behavior

Fedora's build system is able to build borgmatic using pyproject.toml alone.

Other notes / implementation ideas

No response

borgmatic version

1.9.1

borgmatic installation method

No response

Borg version

No response

Python version

3.13.0

Database version (if applicable)

No response

Operating system and version

Fedora Linux 41 (Workstation Edition)

### What I'm trying to do and why `pyproject.yaml` is missing the `build-backend` key. [It's there, but commented out](https://projects.torsion.org/borgmatic-collective/borgmatic/src/commit/22776b123d5b6192aff26d1bb1cd23d2b945d1ff/pyproject.toml#L41). Fedora's buildsystem, in adherence with PEP 517, will then try to execute the non-existent `setup.py`. Relevant PEP 517 quote: > If the pyproject.toml file is absent, or the build-backend key is missing, the source tree is not using this specification, and tools should revert to the legacy behaviour of running setup.py (either directly, or by implicitly invoking the setuptools.build_meta:__legacy__ backend). ### Steps to reproduce Downloading the [latest borgmatic RPM spec file](https://src.fedoraproject.org/rpms/borgmatic/blob/rawhide/f/borgmatic.spec) and try building it locally or in mock. ### Actual behavior Snippet from Fedora buildsystem: ``` + /usr/bin/python3 -Bs /usr/lib/rpm/redhat/pyproject_buildrequires.py --generate-extras --python3_pkgversion 3 --wheeldir /builddir/build/BUILD/borgmatic-1.9.1-build/pyproject-wheeldir --output /builddir/build/BUILD/borgmatic-1.9.1-build/borgmatic-1.9.1-2.fc42.x86_64-pyproject-buildrequires Handling setuptools>=61.0 from build-system.requires Requirement not satisfied: setuptools>=61.0 Traceback (most recent call last): File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 721, in main generate_requires( ~~~~~~~~~~~~~~~~~^ include_runtime=args.runtime, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ...<11 lines>... config_settings=parse_config_settings_args(args.config_settings), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ) ^ File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 602, in generate_requires backend = get_backend(requirements) File "/usr/lib/rpm/redhat/pyproject_buildrequires.py", line 263, in get_backend raise FileNotFoundError('File "setup.py" not found for legacy project.') FileNotFoundError: File "setup.py" not found for legacy project. ``` ### Expected behavior Fedora's build system is able to build borgmatic using `pyproject.toml` alone. ### Other notes / implementation ideas _No response_ ### borgmatic version 1.9.1 ### borgmatic installation method _No response_ ### Borg version _No response_ ### Python version 3.13.0 ### Database version (if applicable) _No response_ ### Operating system and version Fedora Linux 41 (Workstation Edition)

witten commented 2024-11-11 01:09:40 +00:00

Owner

Copy Link

Thanks for filing this. This is fixed in main and will be part of the next release!

Thanks for filing this. This is fixed in main and will be part of the next release!

witten closed this issue 2024-11-11 01:09:40 +00:00

witten referenced this issue from a commit 2024-11-11 01:09:41 +00:00

Fix missing build backend setting in pyproject.toml to allow Fedora builds (#932).

witten referenced this issue 2024-11-11 01:10:41 +00:00

pyproject-transition #922

witten commented 2024-11-19 04:46:02 +00:00

Owner

Copy Link

Released in borgmatic 1.9.2!

Released in borgmatic 1.9.2!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

No results found.

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#932

No description provided.