soft fail is harder than hard fail or error #921

New Issue

Closed

opened 2024-10-06 22:35:56 +00:00 by juestr · 5 comments

juestr commented 2024-10-06 22:35:56 +00:00

Copy Link

What I'm trying to do and why

I am backing up to multiple not always connected repositories.

In a before_backup script, returning a soft fail stops processing of all repositories in the same config file.

I understand the workaround with multiple config files, but I think it's highly inconvenient and inconsistent. A hard fail does not short-circuit following repositories, an neither does an error.

Steps to reproduce

No response

Actual behavior

borgmatic exits on a soft fail immediately

Expected behavior

A soft fail should end processing of the current repository only, like a hard fail or error.

Other notes / implementation ideas

No response

borgmatic version

1.8.13

borgmatic installation method

brew

Borg version

1.4.0

Python version

3.12.7

Database version (if applicable)

No response

Operating system and version

OSX 14.6.1

### What I'm trying to do and why I am backing up to multiple not always connected repositories. In a before_backup script, returning a soft fail stops processing of all repositories in the same config file. I understand the workaround with multiple config files, but I think it's highly inconvenient and inconsistent. A hard fail does *not* short-circuit following repositories, an neither does an error. ### Steps to reproduce _No response_ ### Actual behavior borgmatic exits on a soft fail immediately ### Expected behavior A soft fail should end processing of the current repository *only*, like a hard fail or error. ### Other notes / implementation ideas _No response_ ### borgmatic version 1.8.13 ### borgmatic installation method brew ### Borg version 1.4.0 ### Python version 3.12.7 ### Database version (if applicable) _No response_ ### Operating system and version OSX 14.6.1

witten commented 2024-10-06 22:56:05 +00:00

Owner

Copy Link

Thanks for taking the time to file this!

I'm fine changing this behavior for the reasons you state. (I think it's literally a one line change + test updates.) But technically this would be a breaking change, since some users may be expecting the currently documented behavior of a soft failure hook "wrapping" all repositories in a configuration file instead of just one of them. So that might just require updating the docs and making a bigger version bump along with the change.

Thanks for taking the time to file this! I'm fine changing this behavior for the reasons you state. (I think it's literally a one line change + test updates.) But technically this would be a breaking change, since some users may be expecting the currently documented behavior of a soft failure hook "wrapping" all repositories in a configuration file instead of just one of them. So that might just require updating the docs and making a bigger version bump along with the change.

juestr commented 2024-10-06 23:19:02 +00:00

Author

Copy Link

Thanks for the fast answer. A version bump is sensible and probably the cleanest.

Alternatives might be a new config option "continue_on_soft_fail" or defining an alternate exit code with the new behavior.

Thanks for the fast answer. A version bump is sensible and probably the cleanest. Alternatives might be a new config option "continue_on_soft_fail" or defining an alternate exit code with the new behavior.

witten commented 2024-10-06 23:22:12 +00:00

Owner

Copy Link

Alternatives might be a new config option "continue_on_soft_fail" or defining an alternate exit code with the new behavior.

Command hooks are run per-repository rather than per-config file (ever since borgmatic 1.6.0!), so I think it makes sense for their effects to be per-repository too. Hopefully nobody will miss the current behavior...

> Alternatives might be a new config option "continue_on_soft_fail" or defining an alternate exit code with the new behavior. Command hooks are run per-repository rather than per-config file (ever since borgmatic 1.6.0!), so I think it makes sense for their effects to be per-repository too. Hopefully nobody will miss the current behavior...

witten referenced this issue from a commit 2024-10-07 00:39:26 +00:00

Change soft failure command hooks to skip only the current repository (#921).

witten commented 2024-10-07 00:39:38 +00:00

Owner

Copy Link

Implemented in main! This will be part of the next release. Thanks again!

Implemented in main! This will be part of the next release. Thanks again!

👍 1

witten closed this issue 2024-10-07 00:39:38 +00:00

witten commented 2024-11-03 21:35:01 +00:00

Owner

Copy Link

Released in borgmatic 1.9.0!

Released in borgmatic 1.9.0!

👍 1

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

No results found.

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#921

No description provided.