When databases are configured, don't auto-enable the "one_file_system" option #918

New Issue

Closed

opened 2024-10-01 16:13:09 +00:00 by witten · 2 comments

witten commented 2024-10-01 16:13:09 +00:00

Owner

Copy Link

What I'd like to do and why

Currently, when databases are configured in borgmatic, that auto-enables both the "read_special" option and the "one_file_system" option. The "read_special" option is to support database dump streaming, and the "one_file_system" option is reduce the chance of Borg finding a special file and hanging on it given that "read_special" is enabled.

However, since that arrangement was initially made, borgmatic gained a feature that detects individual special files and auto-excludes them from the set of source files handed to Borg, thereby hopefully sidestepping the hang issue. For that reason, auto-enabling "one_file_system" may no longer be necessary, and in fact can cause problems of its own when auto-enabled.

So as part of this ticket, look into making the database code path no longer auto-enable "one_file_system". Test this on real-world scenarios to ensure that the auto-excluding feature is sufficient.

Other notes / implementation ideas

No response

### What I'd like to do and why Currently, when databases are configured in borgmatic, that [auto-enables](https://torsion.org/borgmatic/docs/how-to/backup-your-databases/#limitations) both the "read_special" option and the "one_file_system" option. The "read_special" option is to support database dump streaming, and the "one_file_system" option is reduce the chance of Borg finding a special file and hanging on it given that "read_special" is enabled. However, since that arrangement was initially made, borgmatic gained a feature that detects individual special files and auto-excludes them from the set of source files handed to Borg, thereby hopefully sidestepping the hang issue. For that reason, auto-enabling "one_file_system" may no longer be necessary, and in fact [can cause problems of its own when auto-enabled](https://projects.torsion.org/borgmatic-collective/borgmatic/issues/903). So as part of this ticket, look into making the database code path no longer auto-enable "one_file_system". Test this on real-world scenarios to ensure that the auto-excluding feature is sufficient. ### Other notes / implementation ideas _No response_

witten referenced this issue from a commit 2024-10-01 17:17:59 +00:00

When databases are configured, don't auto-enable the "one_file_system" option (#918).

witten commented 2024-10-01 17:37:46 +00:00

Author

Owner

Copy Link

Implemented in main and will be part of the next release! Feedback welcome.

Implemented in main and will be part of the next release! Feedback welcome.

witten closed this issue 2024-10-01 17:37:52 +00:00

witten commented 2024-11-03 21:34:23 +00:00

Author

Owner

Copy Link

Released in borgmatic 1.9.0!

Released in borgmatic 1.9.0!

witten referenced this issue 2024-11-07 15:41:42 +00:00

Silent REGRESSION in 1.8.10: backing up either files or database #903

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

No results found.

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#918

No description provided.