Cannot change repository passphrase (borg change-passphrase) #911

New Issue

Closed

opened 2024-09-01 13:21:20 +00:00 by sumpfralle · 3 comments

sumpfralle commented 2024-09-01 13:21:20 +00:00

Copy Link

What I'd like to do and why

I tried to change the passphrase of the backup repository via borgmatic borg key:

root@example:~# borgmatic borg key change-passphrase 
Borg's key subcommand is supported natively by borgmatic. Try this instead: borgmatic key

I took a look at the code: the above warning is really just a warning. The subcommand is executed anyway. This is good.

But the action seems to fail (or just do nothing). Maybe this is related to stdin / interactivity handling of borgmatic.

Then I tried to follow the advice of using borgmatic's integrated key action:

root@example:~# borgmatic key change-passphrase
Missing sub-action after key action. Expected one of: export

Need some help? https://torsion.org/borgmatic/#issues

Thus, I see two issues:

• The warning message regarding the natively supported key subcommand does not take the chosen sub-sub-command into account. But I failed to come up with a better phrasing for this message. Thus, probably it is not worth being changed.
• The interactive borg key change-passphrase action does not seem to work while being wrapped into borgmatic.

I am not sure, whether password changes are within the desired scope of borgmatic. Thus, you may feel free to close this issue if this is not the case.

Thank you for your time!

Other notes / implementation ideas

No response

### What I'd like to do and why I tried to change the passphrase of the backup repository via `borgmatic borg key`: ``` root@example:~# borgmatic borg key change-passphrase Borg's key subcommand is supported natively by borgmatic. Try this instead: borgmatic key ``` I took a look at the code: the above warning is really just a warning. The subcommand is executed anyway. This is good. But the action seems to fail (or just do nothing). Maybe this is related to stdin / interactivity handling of borgmatic. Then I tried to follow the advice of using borgmatic's integrated `key` action: ``` root@example:~# borgmatic key change-passphrase Missing sub-action after key action. Expected one of: export Need some help? https://torsion.org/borgmatic/#issues ``` Thus, I see two issues: * The warning message regarding the natively supported `key` subcommand does not take the chosen sub-sub-command into account. But I failed to come up with a better phrasing for this message. Thus, probably it is not worth being changed. * The interactive `borg key change-passphrase` action does not seem to work while being wrapped into `borgmatic`. I am not sure, whether password changes are within the desired scope of borgmatic. Thus, you may feel free to close this issue if this is not the case. Thank you for your time! ### Other notes / implementation ideas _No response_

witten commented 2024-09-01 13:45:18 +00:00

Owner

Copy Link

Thanks for taking the time to file this! I can confirm both of the issues you've identified. The not taking the sub-sub-command into account in the warning is unfortunate, but yeah, may or may not be worth attempting to fix. But the lack of borgmatic wrapping change-passphrase seems like something pretty straightforward to implement and within the scope of what borgmatic can/should do.

But the action seems to fail (or just do nothing). Maybe this is related to stdin / interactivity handling of borgmatic.

This is a likely cause. One of the downsides of the borgmatic borg escape hatch is that the "wrapped" commands aren't truly wrapped, and so borgmatic isn't smart enough to know what to do with input/output.

Thanks for taking the time to file this! I can confirm both of the issues you've identified. The not taking the sub-sub-command into account in the warning is unfortunate, but yeah, may or may not be worth attempting to fix. But the lack of borgmatic wrapping [`change-passphrase`](https://borgbackup.readthedocs.io/en/stable/usage/key.html) seems like something pretty straightforward to implement and within the scope of what borgmatic can/should do. > But the action seems to fail (or just do nothing). Maybe this is related to stdin / interactivity handling of borgmatic. This is a likely cause. One of the downsides of the `borgmatic borg` escape hatch is that the "wrapped" commands aren't truly wrapped, and so borgmatic isn't smart enough to know what to do with input/output.

witten referenced this issue from a commit 2024-09-01 18:13:58 +00:00

Add a "key change-passphrase" action to change the passphrase protecting a repository key (#911).

witten commented 2024-09-01 18:15:44 +00:00

Owner

Copy Link

Wrapping of key change-passphrase is implemented in main and will be part of the next release! Thanks again for the suggestion.

Wrapping of `key change-passphrase` is implemented in main and will be part of the next release! Thanks again for the suggestion.

🚀 1

witten closed this issue 2024-09-01 18:15:44 +00:00

witten added the

new feature area

label 2024-09-01 18:15:52 +00:00

witten referenced this issue from a commit 2024-10-01 16:26:16 +00:00

Add missing test (#911).

witten referenced this issue from a commit 2024-10-01 16:31:17 +00:00

Revert "Add missing test (#911)" which accidentally included unrelated changes.

witten referenced this issue from a commit 2024-10-01 16:31:17 +00:00

Add missing test (#911).

witten referenced this issue from a commit 2024-10-20 23:05:50 +00:00

Fix change-passphrase to actually prompt for a new passphrase when an old one is configured (#911).

witten commented 2024-11-03 21:34:55 +00:00

Owner

Copy Link

Released in borgmatic 1.9.0!

Released in borgmatic 1.9.0!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

No results found.

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label

new feature area

Milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#911

No description provided.