Error in borgmatic init on an existent but empty repository with Borg 1.4.0 #896

New Issue

Closed

opened 2024-07-08 18:18:46 +00:00 by witten · 2 comments

witten commented 2024-07-08 18:18:46 +00:00

Owner

Copy Link

What I'm trying to do and why

As discovered in https://github.com/borgmatic-collective/docker-borgmatic/issues/340, borgmatic init/borgmatic rcreate errors when trying to create a repository in an existent but empty directory with Borg 1.4.0.

Steps to reproduce

test.yaml:

...
repositories:
    - empty.borg
local_path: /root/borg1.4.0
...

$ mkdir empty.borg
$ borgmatic -c test.yaml -v 1 init -e none

Actual behavior

backup: Creating repository
/root/tmp/missing.borg is not a valid repository. Check repo config.
backup: Error running actions for repository
Command '('/root/borg1.4.0', 'info', '--json', 'missing.borg')' returned non-zero exit status 15.
/root/tmp/test.yaml: An error occurred

summary:
/root/tmp/test.yaml: An error occurred
backup: Error running actions for repository
Command '('/root/borg1.4.0', 'info', '--json', 'missing.borg')' returned non-zero exit status 15.

Need some help? https://torsion.org/borgmatic/#issues

Expected behavior

backup: Creating repository
/root/tmp/missing.borg is not a valid repository. Check repo config.
Initializing repository at "missing.borg"
Encryption NOT enabled.
Use the "--encryption=repokey|keyfile" to enable encryption.
Synchronizing chunks cache...
Archives: 0, w/ cached Idx: 0, w/ outdated Idx: 0, w/o cached Idx: 0.
Done.

summary:
/root/tmp/test.yaml: Successfully ran configuration file

Other notes / implementation ideas

The problem is in borg/rcreate.py where borgmatic is not looking for exit code 15 along with the other exit codes for missing repositories:

RINFO_REPOSITORY_NOT_FOUND_EXIT_CODES = {2, 13}

borgmatic version

1.8.13 or main

borgmatic installation method

pipx install --editable

Borg version

1.4.0

Python version

3.12.4

Database version (if applicable)

No response

Operating system and version

Manjaro stable

### What I'm trying to do and why As discovered in https://github.com/borgmatic-collective/docker-borgmatic/issues/340, `borgmatic init`/`borgmatic rcreate` errors when trying to create a repository in an existent but empty directory with Borg 1.4.0. ### Steps to reproduce test.yaml: ```yaml ... repositories: - empty.borg local_path: /root/borg1.4.0 ... ``` ```bash $ mkdir empty.borg $ borgmatic -c test.yaml -v 1 init -e none ``` ### Actual behavior ``` backup: Creating repository /root/tmp/missing.borg is not a valid repository. Check repo config. backup: Error running actions for repository Command '('/root/borg1.4.0', 'info', '--json', 'missing.borg')' returned non-zero exit status 15. /root/tmp/test.yaml: An error occurred summary: /root/tmp/test.yaml: An error occurred backup: Error running actions for repository Command '('/root/borg1.4.0', 'info', '--json', 'missing.borg')' returned non-zero exit status 15. Need some help? https://torsion.org/borgmatic/#issues ``` ### Expected behavior ``` backup: Creating repository /root/tmp/missing.borg is not a valid repository. Check repo config. Initializing repository at "missing.borg" Encryption NOT enabled. Use the "--encryption=repokey|keyfile" to enable encryption. Synchronizing chunks cache... Archives: 0, w/ cached Idx: 0, w/ outdated Idx: 0, w/o cached Idx: 0. Done. summary: /root/tmp/test.yaml: Successfully ran configuration file ``` ### Other notes / implementation ideas The problem is in `borg/rcreate.py` where borgmatic is not looking for exit code 15 along with the other exit codes for missing repositories: ```python RINFO_REPOSITORY_NOT_FOUND_EXIT_CODES = {2, 13} ``` ### borgmatic version 1.8.13 or main ### borgmatic installation method pipx install --editable ### Borg version 1.4.0 ### Python version 3.12.4 ### Database version (if applicable) _No response_ ### Operating system and version Manjaro stable

witten added the

bug

label 2024-07-08 18:22:43 +00:00

witten referenced this issue from a commit 2024-07-08 18:25:00 +00:00

Fix error in borgmatic rcreate/init on empty repository directory with Borg 1.4 (#896).

witten commented 2024-07-08 18:25:12 +00:00

Author

Owner

Copy Link

Fixed in main and will be part of the next release!

Fixed in main and will be part of the next release!

witten closed this issue 2024-07-08 18:25:12 +00:00

witten commented 2024-08-30 00:46:27 +00:00

Author

Owner

Copy Link

Released in borgmatic 1.8.14!

Released in borgmatic 1.8.14!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

config-command-line

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label

bug

Milestone

No items

No Milestone

Assignees

Clear assignees

diivi import_bot witten

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#896

No description provided.