Support showing exit codes with --show-rc #89

New Issue

Closed

opened 2018-08-19 17:54:25 +00:00 by varac · 5 comments

varac commented 2018-08-19 17:54:25 +00:00

Copy Link

Please implement --show-rc to show the exit code of the borg commands.

https://borgbackup.readthedocs.io/en/stable/man_intro.html?highlight=rc#return-codes

Please implement `--show-rc` to show the exit code of the borg commands. https://borgbackup.readthedocs.io/en/stable/man_intro.html?highlight=rc#return-codes

witten commented 2018-08-19 17:58:05 +00:00

Owner

Copy Link

Could you comment as to what you're using the exit codes for? For instance, if you're programmatically parsing the exit codes for some purpose, I want to make sure I don't prevent you from doing that even if this is implemented by interleaving borgmatic logs. Thanks!

Could you comment as to what you're using the exit codes for? For instance, if you're programmatically parsing the exit codes for some purpose, I want to make sure I don't prevent you from doing that even if this is implemented by interleaving borgmatic logs. Thanks!

varac commented 2018-08-19 19:19:19 +00:00

Author

Copy Link

I was debugging my borgmatic systemd timer which failed each time because of a non-0 exit code. I wanted to look in the logs which code it was.

I was debugging my borgmatic systemd timer which failed each time because of a non-0 exit code. I wanted to look in the logs which code it was.

witten commented 2018-08-19 19:20:46 +00:00

Owner

Copy Link

Got it, thanks. Do you think it would make sense to just always pass the --show-rc code to Borg when borgmatic's -v 2 verbosity option is specified? I'm suggesting that because it sounds like a debugging/verbosity aide.

Got it, thanks. Do you think it would make sense to just always pass the `--show-rc` code to Borg when borgmatic's `-v 2` verbosity option is specified? I'm suggesting that because it sounds like a debugging/verbosity aide.

witten referenced this issue from a commit 2018-08-19 19:45:03 +00:00

Pass --show-rc option to Borg when at highest verbosity level (#89).

witten commented 2018-08-19 19:47:07 +00:00

Owner

Copy Link

I went ahead and implemented that. It'll be part of the next release. Note that even without this, I believe that borgmatic logs Borg's exit code in the case that Borg errors. Example:

# borgmatic --list -v 2
...
borg list: error: argument --lock-wait: invalid int value: 'invalid'
...
Command '('borg', 'list', 'user@remote', '--remote-path', 'borg1', '--debug', '--lock-wait', 'invalid', '--show-rc')' returned non-zero exit status 2

I went ahead and implemented that. It'll be part of the next release. Note that even without this, I believe that borgmatic logs Borg's exit code in the case that Borg errors. Example: ```shell # borgmatic --list -v 2 ... borg list: error: argument --lock-wait: invalid int value: 'invalid' ... Command '('borg', 'list', 'user@remote', '--remote-path', 'borg1', '--debug', '--lock-wait', 'invalid', '--show-rc')' returned non-zero exit status 2 ```

witten closed this issue 2018-08-19 19:47:07 +00:00

witten commented 2018-09-27 04:40:29 +00:00

Owner

Copy Link

Released as part of borgmatic 1.2.3!

Released as part of borgmatic 1.2.3!

witten referenced this issue from a commit 2025-02-15 17:57:03 +00:00

Fix path handling error when handling btrfs '/' subvolume.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

command-hook-steps

2.0.13

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

witten

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#89