Healthchecks.io: Default for ping_body_limit #889

New issue

Closed

opened 2024-06-25 19:21:30 +00:00 by mrclschstr · 3 comments

mrclschstr commented 2024-06-25 19:21:30 +00:00

Copy link

What I'm trying to do and why

I noticed a small error with the default value for the ping_body_limit of the healthchecks.io integration. According to the documentation, the default value should be 100000, but I have noticed truncated logs in my checks for some time now.

I have noticed that the default value has changed since the following commit: 9647301b99 (diff-03470cdfb). The variable DEFAULT_PING_BODY_LIMIT_BYTES is now set to 1500 bytes and no longer to 100000.

My current workaround is to set the value for ping_body_limit to 100000 in the borgmatic config.

Steps to reproduce

Just make a backup and inspect the truncated logs in the healthchecks.io checks.

Actual behavior

The logs are truncated.

Expected behavior

The logs should be readable in full and not be cut off using the default value for ping_body_limit.

Other notes / implementation ideas

No response

borgmatic version

1.8.12

borgmatic installation method

pip install

Borg version

borg 1.2.8

Python version

Python 3.10.12

Database version (if applicable)

n/a

Operating system and version

Ubuntu 22.04.4 LTS

### What I'm trying to do and why I noticed a small error with the default value for the `ping_body_limit` of the healthchecks.io integration. According to the [documentation](https://torsion.org/borgmatic/docs/reference/configuration/), the default value should be 100000, but I have noticed truncated logs in my checks for some time now. I have noticed that the default value has changed since the following commit: https://projects.torsion.org/borgmatic-collective/borgmatic/commit/9647301b993fbbe89347cdc2290fa7a458c65a01#diff-03470cdfb71141d2237530601ed560936ffb2273. The variable `DEFAULT_PING_BODY_LIMIT_BYTES` is now set to 1500 bytes and no longer to 100000. My current workaround is to set the value for `ping_body_limit` to 100000 in the borgmatic config. ### Steps to reproduce Just make a backup and inspect the truncated logs in the healthchecks.io checks. ### Actual behavior The logs are truncated. ### Expected behavior The logs should be readable in full and not be cut off using the default value for `ping_body_limit`. ### Other notes / implementation ideas _No response_ ### borgmatic version 1.8.12 ### borgmatic installation method pip install ### Borg version borg 1.2.8 ### Python version Python 3.10.12 ### Database version (if applicable) n/a ### Operating system and version Ubuntu 22.04.4 LTS

witten commented 2024-06-25 19:43:25 +00:00

Owner

Copy link

Thanks for reporting this.. Good catch! I'm not sure why/how this default value regressed, but I do know that the maximum body size on older versions of the Healthchecks server used to be lower. In any case, I'm fine changing it back to 100000. I'm glad you have a work-around for now!

Thanks for reporting this.. Good catch! I'm not sure why/how this default value regressed, but I do know that the maximum body size on older versions of the Healthchecks server used to be lower. In any case, I'm fine changing it back to 100000. I'm glad you have a work-around for now!

witten referenced this issue from a commit 2024-06-25 19:45:58 +00:00

Fix the Healthchecks ping body size limit, restoring it to the documented 100,000 bytes (#889).

witten commented 2024-06-25 19:46:10 +00:00

Owner

Copy link

Fixed in main and will be part of the next release!

Fixed in main and will be part of the next release!

🎉 1

witten closed this issue 2024-06-25 19:46:10 +00:00

witten commented 2024-07-04 15:58:32 +00:00

Owner

Copy link

Released in borgmatic 1.8.13!

Released in borgmatic 1.8.13!

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

parallel-borgmatic

command-hook-steps

2.1.7

2.1.6

2.1.5

2.1.4

2.1.3

2.1.2

2.1.1

2.1.0

2.0.13

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

blocked

  

breaking

  

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

borgmatic-collective/borgmatic#889

No description provided.