Provide repository label as a variable in hooks #874

New Issue

Closed

opened 2024-05-25 18:01:01 +00:00 by sshaikh · 4 comments

sshaikh commented 2024-05-25 18:01:01 +00:00

Copy Link

What I'd like to do and why

I'd like to have access to the label associated with a repository on running of hooks. This is both for aesthetic reasons, but also to call nested borgmatic commands.

Other notes / implementation ideas

Provide {label} in hooks.

### What I'd like to do and why I'd like to have access to the label associated with a repository on running of hooks. This is both for aesthetic reasons, but also to call nested borgmatic commands. ### Other notes / implementation ideas Provide {label} in hooks.

witten referenced this issue from a commit 2024-06-05 21:47:55 +00:00

Add configured repository "label" to the interpolated variables passed to command hooks (#874).

witten commented 2024-06-05 21:48:49 +00:00

Owner

Copy Link

Good idea! This has been implemented in main and will be part of the next release. (EDIT: Calling this "repository_label" instead of "label" for clarity.)

However, I'm interested in what nested borgmatic commands you're calling and why...? Generally I don't recommend calling borgmatic from borgmatic due to infinite recursion risks.

Good idea! This has been implemented in main and will be part of the next release. (EDIT: Calling this "repository_label" instead of "label" for clarity.) However, I'm interested in what nested borgmatic commands you're calling and why...? Generally I don't recommend calling borgmatic from borgmatic due to infinite recursion risks.

witten referenced this issue from a commit 2024-06-05 21:56:48 +00:00

Calling interpolated variable "repository_label" instead of "label" for clarity (#874).

witten referenced this issue from a commit 2024-06-05 21:58:59 +00:00

Alpha ordering in docs (#874).

sshaikh commented 2024-06-05 21:59:52 +00:00

Author

Copy Link

I produce some statistics of the backup just made including the number of changed files, repo size, added chunks etc. Most of this goes into a Prometheus scrape target, but I also send a summary:

BORG: Finished backup of /backup/borg: 33.752306 seconds
466 / 296321 files changed

I'll definitely change the repo name to label, but the only way I know how to get the other stats is with borg list, info and diff... and borgmatic lets me do that trivially via the config file (I'm currently hard coding the repo -> label mapping in anticipation of this feature).

I did think of the danger of recursion, but figured it's an advanced use anyway.

I produce some statistics of the backup just made including the number of changed files, repo size, added chunks etc. Most of this goes into a Prometheus scrape target, but I also send a summary: ``` BORG: Finished backup of /backup/borg: 33.752306 seconds 466 / 296321 files changed ``` I'll definitely change the repo name to label, but the only way I know how to get the other stats is with borg list, info and diff... and borgmatic lets me do that trivially via the config file (I'm currently hard coding the repo -> label mapping in anticipation of this feature). I did think of the danger of recursion, but figured it's an advanced use anyway.

witten commented 2024-06-06 00:30:55 +00:00

Owner

Copy Link

Got it.. Thanks for explaining. You may be interested in #617 which is a similar use case. I'll close this ticket for now since the main ask is implemented.

Got it.. Thanks for explaining. You may be interested in #617 which is a similar use case. I'll close this ticket for now since the main ask is implemented.

witten closed this issue 2024-06-06 00:30:55 +00:00

witten referenced this issue 2024-06-23 23:00:40 +00:00

[Feature] Add label variable interpolation in hook context #861

witten commented 2024-06-24 00:06:09 +00:00

Owner

Copy Link

Released in borgmatic 1.8.12!

Released in borgmatic 1.8.12!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

diivi import_bot witten

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#874

No description provided.