Checks Fail, but were previously working #854

New Issue

Closed

opened 2024-04-21 21:05:05 +00:00 by tehNiemer · 5 comments

tehNiemer commented 2024-04-21 21:05:05 +00:00

Copy Link

What I'm trying to do and why

Run a check

Steps to reproduce

initialize the check with borgmatic check

Actual behavior

Check fails with the below error

Starting checks. 16:01:29 CDT
Traceback (most recent call last):
  File "/root/.local/bin/borgmatic", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic                                                     /commands/borgmatic.py", line 899, in main
    or list(collect_configuration_run_summary_logs(configs, config_paths, argume                                                     nts))
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                     ^^^^^
  File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic                                                     /commands/borgmatic.py", line 781, in collect_configuration_run_summary_logs
    results = list(run_configuration(config_filename, config, config_paths, argu                                                     ments))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                     ^^^^^^^
  File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic                                                     /commands/borgmatic.py", line 143, in run_configuration
    yield from run_actions(
  File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic                                                     /commands/borgmatic.py", line 368, in run_actions
    borgmatic.actions.check.run_check(
  File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic                                                     /actions/check.py", line 622, in run_check
    borgmatic.borg.check.check_archives(
  File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic                                                     /borg/check.py", line 140, in check_archives
    + make_check_flags(checks, archive_filter_flags)
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic                                                     /borg/check.py", line 71, in make_check_flags
    checks += ('archives',)
TypeError: unsupported operand type(s) for +=: 'set' and 'tuple'

Expected behavior

Check does not fail.

Other notes / implementation ideas

No response

borgmatic version

1.8.10

borgmatic installation method

pip install

Borg version

1.2.4

Python version

3.11.2

Database version (if applicable)

No response

Operating system and version

Debian GNU/Linux 12 (bookworm)

### What I'm trying to do and why Run a check ### Steps to reproduce initialize the check with `borgmatic check` ### Actual behavior Check fails with the below error ``` Starting checks. 16:01:29 CDT Traceback (most recent call last): File "/root/.local/bin/borgmatic", line 8, in <module> sys.exit(main()) ^^^^^^ File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic /commands/borgmatic.py", line 899, in main or list(collect_configuration_run_summary_logs(configs, config_paths, argume nts)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic /commands/borgmatic.py", line 781, in collect_configuration_run_summary_logs results = list(run_configuration(config_filename, config, config_paths, argu ments)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^ File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic /commands/borgmatic.py", line 143, in run_configuration yield from run_actions( File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic /commands/borgmatic.py", line 368, in run_actions borgmatic.actions.check.run_check( File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic /actions/check.py", line 622, in run_check borgmatic.borg.check.check_archives( File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic /borg/check.py", line 140, in check_archives + make_check_flags(checks, archive_filter_flags) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/root/.local/pipx/venvs/borgmatic/lib/python3.11/site-packages/borgmatic /borg/check.py", line 71, in make_check_flags checks += ('archives',) TypeError: unsupported operand type(s) for +=: 'set' and 'tuple' ``` ### Expected behavior Check does not fail. ### Other notes / implementation ideas _No response_ ### borgmatic version 1.8.10 ### borgmatic installation method pip install ### Borg version 1.2.4 ### Python version 3.11.2 ### Database version (if applicable) _No response_ ### Operating system and version Debian GNU/Linux 12 (bookworm)

witten commented 2024-04-21 21:12:32 +00:00

Owner

Copy Link

Ugh, this definitely sounds like a bug.. Thanks for filing it! Can I get a look at the checks: section of your configuration?

Ugh, this definitely sounds like a bug.. Thanks for filing it! Can I get a look at the `checks:` section of your configuration?

witten added the

bug

label 2024-04-21 21:12:39 +00:00

tehNiemer commented 2024-04-21 21:37:37 +00:00

Author

Copy Link

Sure thing, here it is.

checks:
    - name: archives
      frequency: 2 weeks
    - name: data
      frequency: 1 month

Sure thing, here it is. ``` checks: - name: archives frequency: 2 weeks - name: data frequency: 1 month ```

witten commented 2024-04-21 21:43:52 +00:00

Owner

Copy Link

Got it, thanks! It repros here. The problem seems to be the data check in particular. So if you'd like to omit that one until this issue is fixed, that would at least unblock you to continue running borgmatic check.

Got it, thanks! It repros here. The problem seems to be the `data` check in particular. So if you'd like to omit that one until this issue is fixed, that would at least unblock you to continue running `borgmatic check`.

witten referenced this issue from a commit 2024-04-21 21:55:21 +00:00

Fix a traceback when the "data" consistency check is used (#854).

witten commented 2024-04-21 21:55:39 +00:00

Owner

Copy Link

This has been fixed in main and will be part of the next release. Thanks again for reporting this!

This has been fixed in main and will be part of the next release. Thanks again for reporting this!

witten closed this issue 2024-04-21 21:55:40 +00:00

witten referenced this issue 2024-04-24 15:43:14 +00:00

Type error with newly initialized repo #857

witten commented 2024-04-29 16:41:56 +00:00

Owner

Copy Link

Released in borgmatic 1.8.11!

Released in borgmatic 1.8.11!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#854

No description provided.