Setting --strip-components all leads to no files being extracted #851

New Issue

Closed

opened 2024-04-17 22:26:36 +00:00 by christian-heusel · 3 comments

christian-heusel commented 2024-04-17 22:26:36 +00:00

Copy Link

What I'm trying to do and why

I had found a bug which wiped the database of my headscale service so I wanted to restore the database from backup. The database is sqlite and just backup'ed as a regular file.

Steps to reproduce

1. Extract the file from backup:

    borgmatic extract --archive latest --strip-components all --path "/opt/docker/headscale/data/db.sqlite"
   

2. Try to find the extracted file (no results):

   find / -type f -name "db.sqlite"
   

Actual behavior

No file is extracted.

Expected behavior

The file is extracted from backup like it is without setting --strip-component all:

borgmatic extract --archive latest --path "/opt/docker/headscale/data/db.sqlite"

Which after you find the extracted file in$PWD/opt/docker/headscale/data/db.sqlite
I would expect the file to be extracted to $PWD/db.sqlite with the command from the repro steps.

Other notes / implementation ideas

I also have an Arch Linux install with version 1.8.10 and the issue also is present.

borgmatic version

1.8.9

borgmatic installation method

Debian package

Borg version

1.2.7

Python version

3.11.8

Database version (if applicable)

No response

Operating system and version

Debian GNU/Linux trixie/sid

### What I'm trying to do and why I had found [a bug](https://github.com/juanfont/headscale/pull/1878) which wiped the database of my headscale service so I wanted to restore the database from backup. The database is sqlite and just backup'ed as a regular file. ### Steps to reproduce 1. Extract the file from backup: ``` borgmatic extract --archive latest --strip-components all --path "/opt/docker/headscale/data/db.sqlite" ``` 2. Try to find the extracted file (no results): ``` find / -type f -name "db.sqlite" ``` ### Actual behavior No file is extracted. ### Expected behavior The file is extracted from backup like it is without setting `--strip-component all`: ``` borgmatic extract --archive latest --path "/opt/docker/headscale/data/db.sqlite" ``` Which after you find the extracted file in`$PWD/opt/docker/headscale/data/db.sqlite` I would expect the file to be extracted to `$PWD/db.sqlite` with the command from the repro steps. ### Other notes / implementation ideas I also have an Arch Linux install with version 1.8.10 and the issue also is present. ### borgmatic version 1.8.9 ### borgmatic installation method Debian package ### Borg version 1.2.7 ### Python version 3.11.8 ### Database version (if applicable) _No response_ ### Operating system and version Debian GNU/Linux trixie/sid

witten commented 2024-04-17 23:38:03 +00:00

Owner

Copy Link

Good catch.. What's apparently going on is that the --path value in your example has a leading slash, which causes the number of path components to strip to be miscalculated (off-by-one error), which causes Borg to ignore the path since the provided number of components to strip exceed the number of components in the path!

Borg stores file paths within its archives without a leading slash, but apparently allows leading slashes on paths given to extract. So borgmatic with --strip-components all should IMO be made to work that way as well. I'll make that fix as part of this ticket, but in the meantime you can just drop the leading slash and your example should work fine with the version of borgmatic you're using.

Thanks for bringing this to my attention and slogging through the registration process.

Good catch.. What's apparently going on is that the `--path` value in your example has a leading slash, which causes the number of path components to strip to be miscalculated (off-by-one error), which causes Borg to ignore the path since the provided number of components to strip exceed the number of components in the path! Borg stores file paths within its archives without a leading slash, but apparently allows leading slashes on paths given to `extract`. So borgmatic with `--strip-components all` should IMO be made to work that way as well. I'll make that fix as part of this ticket, but in the meantime you can just drop the leading slash and your example should work fine with the version of borgmatic you're using. Thanks for bringing this to my attention and slogging through the registration process.

witten added the

bug

label 2024-04-17 23:38:52 +00:00

witten referenced this issue from a commit 2024-04-17 23:50:25 +00:00

Fix lack of file extraction when using "extract --strip-components all" on a path with a leading slash (#851).

witten commented 2024-04-17 23:50:46 +00:00

Owner

Copy Link

Fixed in main! It'll be part of the next release. Thanks again.

Fixed in main! It'll be part of the next release. Thanks again.

🎉 1

witten closed this issue 2024-04-17 23:50:46 +00:00

witten commented 2024-04-29 16:41:51 +00:00

Owner

Copy Link

Released in borgmatic 1.8.11!

Released in borgmatic 1.8.11!

🎉 1

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#851

No description provided.