missing finish state ping in case of soft failure #842

New Issue

Closed

opened 2024-03-18 19:49:55 +00:00 by aspik · 4 comments

aspik commented 2024-03-18 19:49:55 +00:00

Copy Link

What I'm trying to do and why

I configured borgmatic with a soft failure as the remote machine will be occasionally online. I'm using Healthchecks to monitor my crontabs. When the backups starts, the start state pings Healthchecks. The action successful finishes with the 75 exit code (although no backup was done, as the remote machine is offline). On Healthchecks the check hangs in a in progress state as Healthchecks API received start but no finish. It is possible to adjust the config, so it sends finish to Healthchecks, when it exits with a soft failure?

Steps to reproduce

source_directories:
- /home/user/data/immich/

exclude_patterns:
- /home/user/data/immich/thumbs/
- /home/user/data/immich/encoded-video/

repositories:
- path: ssh://user@192.168.1.223/media/backups/immich-onsite
label: onsite

keep_daily: 7
keep_weekly: 4
keep_monthly: 6

encryption_passphrase: "***"

postgresql_databases:
- name: immich
hostname: 127.0.0.1
port: 5432
username: postgres
password: postgres
pg_dump_command: docker exec immich_postgres pg_dump

healthchecks:
ping_url: http://192.168.1.217:8000/ping/69c42c71-c919-4136-b1d0-228e17b1405d

before_backup:
- ping -q -c 1 192.168.1.223 > /dev/null || exit 75

Actual behavior

/home/user/.config/borgmatic/immich_onsite.yaml: Pinging Healthchecks start
/home/user/.config/borgmatic/immich_onsite.yaml: Running command for pre-backup hook
/home/user/.config/borgmatic/immich_onsite.yaml: Command hook exited with soft failure exit code (75); skipping remaining actions

summary:
/home/user/.config/borgmatic/immich_onsite.yaml: Successfully ran configuration file

Expected behavior

Send finish to Healthcheck app in case of a soft failure exit.

Other notes / implementation ideas

No response

borgmatic version

1.8.9

borgmatic installation method

pipx

Borg version

1.2.7

Python version

3.11.2

Database version (if applicable)

No response

Operating system and version

Debian GNU/Linux 12 (bookworm)

### What I'm trying to do and why I configured borgmatic with a soft failure as the remote machine will be occasionally online. I'm using Healthchecks to monitor my crontabs. When the backups starts, the start state pings Healthchecks. The action successful finishes with the 75 exit code (although no backup was done, as the remote machine is offline). On Healthchecks the check hangs in a in progress state as Healthchecks API received start but no finish. It is possible to adjust the config, so it sends finish to Healthchecks, when it exits with a soft failure? ### Steps to reproduce source_directories: - /home/user/data/immich/ exclude_patterns: - /home/user/data/immich/thumbs/ - /home/user/data/immich/encoded-video/ repositories: - path: ssh://user@192.168.1.223/media/backups/immich-onsite label: onsite keep_daily: 7 keep_weekly: 4 keep_monthly: 6 encryption_passphrase: "***" postgresql_databases: - name: immich hostname: 127.0.0.1 port: 5432 username: postgres password: postgres pg_dump_command: docker exec immich_postgres pg_dump healthchecks: ping_url: http://192.168.1.217:8000/ping/69c42c71-c919-4136-b1d0-228e17b1405d before_backup: - ping -q -c 1 192.168.1.223 > /dev/null || exit 75 ### Actual behavior /home/user/.config/borgmatic/immich_onsite.yaml: Pinging Healthchecks start /home/user/.config/borgmatic/immich_onsite.yaml: Running command for pre-backup hook /home/user/.config/borgmatic/immich_onsite.yaml: Command hook exited with soft failure exit code (75); skipping remaining actions summary: /home/user/.config/borgmatic/immich_onsite.yaml: Successfully ran configuration file ### Expected behavior Send finish to Healthcheck app in case of a soft failure exit. ### Other notes / implementation ideas _No response_ ### borgmatic version 1.8.9 ### borgmatic installation method pipx ### Borg version 1.2.7 ### Python version 3.11.2 ### Database version (if applicable) _No response_ ### Operating system and version Debian GNU/Linux 12 (bookworm)

witten commented 2024-03-18 21:40:22 +00:00

Owner

Copy Link

Thanks for taking the time to file this one! What you describe—pinging Healtchecks/monitoring with "finish" in the case of soft failure—seems totally reasonable to me. It's not currently possible to change this behavior in borgmatic's configuration, but IMO it would make sense to change borgmatic's default behavior so that the "finish" state is pinged whenever there's a soft failure.

Thanks for taking the time to file this one! What you describe—pinging Healtchecks/monitoring with "finish" in the case of soft failure—seems totally reasonable to me. It's not currently possible to change this behavior in borgmatic's configuration, but IMO it would make sense to change borgmatic's default behavior so that the "finish" state is pinged whenever there's a soft failure.

witten referenced this issue from a commit 2024-03-19 06:16:01 +00:00

When a command hook exits with a soft failure, ping the log and finish states for any configured monitoring hooks (#842).

witten commented 2024-03-19 06:16:18 +00:00

Owner

Copy Link

This is implemented in main and will be part of the next release! Thanks again.

This is implemented in main and will be part of the next release! Thanks again.

witten closed this issue 2024-03-19 06:16:18 +00:00

witten commented 2024-04-16 17:45:05 +00:00

Owner

Copy Link

Released in 1.8.10!

Released in 1.8.10!

aspik commented 2024-04-16 19:42:58 +00:00

Author

Copy Link

Nice. Thank you!

Nice. Thank you!

👍 1

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#842

No description provided.