Custom command options for MongoDB hook #837

New Issue

Closed

opened 2024-03-03 22:42:11 +00:00 by witten · 8 comments

witten commented 2024-03-03 22:42:11 +00:00

Owner

Copy Link

What I'd like to do and why

Implement two new configuration option for the existing MongoDB hook to run custom MongoDB command for each of dumping and restoring instead of the defaults (mongodump and mongorestore, respectively).

Broken off from #311.

Other notes / implementation ideas

Make sure to use shlex shell escaping to prevent shell injections attacks. See the other database hooks for an example.

### What I'd like to do and why Implement two new configuration option for the existing MongoDB hook to run custom MongoDB command for each of dumping and restoring instead of the defaults (`mongodump` and `mongorestore`, respectively). Broken off from #311. ### Other notes / implementation ideas Make sure to use `shlex` shell escaping to prevent shell injections attacks. See the other database hooks for an example.

witten added the good first issue label 2024-03-03 22:42:18 +00:00

shivansh02 commented 2024-03-04 03:21:27 +00:00

Copy Link

I can take care of this and #836 (unless you want me to save them for others 😄).

I can take care of this and #836 (unless you want me to save them for others 😄).

witten commented 2024-03-04 03:36:55 +00:00

Author

Owner

Copy Link

Nobody else has stepped up in the five hours since these tickets have existed, so as far as I'm concerned they're all yours if you want 'em. 😄

Nobody else has stepped up in the five hours since these tickets have existed, so as far as I'm concerned they're all yours if you want 'em. 😄

witten referenced this issue 2024-08-20 21:51:02 +00:00

Documentation and config schema update for #906 #907

gautamaggarwal2810 commented 2025-03-13 12:51:25 +00:00

Contributor

Copy Link

I would like to work on this issue. @witten can u please guide me as to how to get started as I am new to open source?

I would like to work on this issue. @witten can u please guide me as to how to get started as I am new to open source?

witten commented 2025-03-13 16:32:07 +00:00

Author

Owner

Copy Link

Welcome! I'd recommend starting with the docs on how to get started with development. And if you want to outline your approach to the ticket here, I'd be happy to provide feedback before you start writing code. But it's also small enough that you could probably just submit a PR if you don't mind the risk of re-work.

In terms of the mechanics of submitting your changes, here are some docs on submitting a pull request.

And let me know if you have any questions!

Welcome! I'd recommend starting with the [docs on how to get started with development](https://torsion.org/borgmatic/docs/how-to/develop-on-borgmatic/). And if you want to outline your approach to the ticket here, I'd be happy to provide feedback before you start writing code. But it's also small enough that you could probably just submit a PR if you don't mind the risk of re-work. In terms of the mechanics of submitting your changes, [here are some docs on submitting a pull request](https://docs.gitea.com/next/usage/pull-request). And let me know if you have any questions!

gautamaggarwal2810 referenced this issue 2025-03-14 12:54:14 +00:00

Custom command option for SQLite hook #836

witten commented 2025-03-16 21:35:29 +00:00

Author

Owner

Copy Link

I got an email notification about a question you had on this, but I'm not seeing the comment posted here. Did you figure out the issue you were having?

I got an email notification about a question you had on this, but I'm not seeing the comment posted here. Did you figure out the issue you were having?

gautamaggarwal2810 commented 2025-03-17 05:04:15 +00:00

Contributor

Copy Link

I got an email notification about a question you had on this, but I'm not seeing the comment posted here. Did you figure out the issue you were having?
yeah I was able to figure out the issue.Thanks ☺️.I will be submitting PR soon.

> I got an email notification about a question you had on this, but I'm not seeing the comment posted here. Did you figure out the issue you were having? yeah I was able to figure out the issue.Thanks ☺️.I will be submitting PR soon.

👍 1

gautamaggarwal2810 referenced this issue 2025-03-17 07:35:49 +00:00

WIP: Custom command options for MongoDB hook #837 #1029

gautamaggarwal2810 referenced this issue 2025-03-24 04:05:25 +00:00

Custom command options for MongoDB hook #837 #1041

witten referenced this issue from a commit 2025-03-26 05:27:05 +00:00

Custom command options for MongoDB hook #837

witten referenced this issue from a commit 2025-03-26 05:27:05 +00:00

Add custom command options for MongoDB hook (#837).

witten referenced this issue from a commit 2025-03-26 05:28:50 +00:00

Add MongoDB custom command options to NEWS (#837).

witten commented 2025-03-26 05:29:20 +00:00

Author

Owner

Copy Link

Implemented in main by @gautamaggarwal2810 and will be part of the next release!

Implemented in main by @gautamaggarwal2810 and will be part of the next release!

witten closed this issue 2025-03-26 05:29:20 +00:00

witten referenced this issue from a commit 2025-03-26 05:32:34 +00:00

Fix line wrapping / code style (#837).

witten commented 2025-04-06 15:44:12 +00:00

Author

Owner

Copy Link

Released in borgmatic 2.0.0!

Released in borgmatic 2.0.0!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

logging-execution-fixes

command-hook-steps

2.0.13

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label good first issue

Milestone

No items

No Milestone

Assignees

Clear assignees

witten

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#837