Custom command option for SQLite hook #836

New Issue

Closed

opened 2024-03-03 22:39:44 +00:00 by witten · 6 comments

witten commented 2024-03-03 22:39:44 +00:00

Owner

Copy Link

What I'd like to do and why

Implement a new configuration option for the existing SQLite hook to run a custom SQLite command for dumping or restoring instead of the default sqlite3.

Broken off from #311.

Other notes / implementation ideas

Make sure to use shlex shell escaping to prevent shell injections attacks. See the other database hooks for an example.

### What I'd like to do and why Implement a new configuration option for the existing SQLite hook to run a custom SQLite command for dumping or restoring instead of the default `sqlite3`. Broken off from #311. ### Other notes / implementation ideas Make sure to use `shlex` shell escaping to prevent shell injections attacks. See the other database hooks for an example.

👍 1

witten added the good first issue label 2024-03-03 22:39:52 +00:00

witten changed title from Custom command options for SQLite hook to Custom command option for SQLite hook 2024-03-03 22:40:15 +00:00

shivansh02 referenced this issue 2024-03-04 03:21:27 +00:00

Custom command options for MongoDB hook #837

mkarg commented 2024-03-28 18:33:57 +00:00

Copy Link

Such an option (in analogy to the ones for PostgreSQL) would also be very useful in case sqlite3 has to execute within a container, while borgmatic is running on the host. At least until borgmatic comes up with a global option that says "run this hook in a docker container".

Such an option (in analogy to the ones for PostgreSQL) would also be very useful in case sqlite3 has to execute within a container, while borgmatic is running on the host. At least until borgmatic comes up with a *global* option that says "run this hook in a docker container".

witten commented 2024-03-31 00:26:37 +00:00

Author

Owner

Copy Link

Yeah, unlocking use cases like that is one of the primary reasons to do this ticket!

Yeah, unlocking use cases like that is one of the primary reasons to do this ticket!

120EE0980 commented 2025-03-14 06:46:58 +00:00

Contributor

Copy Link

I want to work on this issue.

I want to work on this issue.

gautamaggarwal2810 commented 2025-03-14 12:54:14 +00:00

Contributor

Copy Link

I am working on a similar issue #837 . Is it alright if I work on this too?

I am working on a similar issue #837 . Is it alright if I work on this too?

witten commented 2025-03-14 16:47:46 +00:00

Author

Owner

Copy Link

@120EE0980 commented first, so unless they want to give up the ticket, I'd say it's theirs to implement for now. With a larger ticket, there might be an opportunity to collaborate, but I think this one is pretty small.

@gautamaggarwal2810, there are plenty of other "good first issues" issues though to choose from. Hopefully something there looks interesting to you.

I will say that I appreciate both of your interest here!

@120EE0980 commented first, so unless they want to give up the ticket, I'd say it's theirs to implement for now. With a larger ticket, there might be an opportunity to collaborate, but I think this one is pretty small. @gautamaggarwal2810, there are plenty of other ["good first issues"](https://projects.torsion.org/borgmatic-collective/borgmatic/issues?q=&type=all&state=open&labels=52&milestone=0&assignee=0&poster=) issues though to choose from. Hopefully something there looks interesting to you. I will say that I appreciate both of your interest here!

👍 2

120EE0980 referenced a pull request that will close this issue 2025-03-15 17:10:17 +00:00

Add custom command option for SQLite hook #1027

witten closed this issue 2025-03-16 04:34:16 +00:00

witten referenced this issue from a commit 2025-03-16 04:34:17 +00:00

Add custom command option for SQLite hook (#836).

witten referenced this issue from a commit 2025-03-16 04:43:22 +00:00

Add SQLite custom command option to NEWS (#836).

witten referenced this issue from a commit 2025-03-16 04:43:22 +00:00

Updated outdated schema comment referencing ~/.borgmatic path (#836).

witten commented 2025-04-06 15:44:30 +00:00

Author

Owner

Copy Link

Released in borgmatic 2.0.0!

Released in borgmatic 2.0.0!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

logging-execution-fixes

command-hook-steps

2.0.13

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

No Label good first issue

Milestone

No items

No Milestone

Assignees

Clear assignees

witten

No Assignees

4 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#836