borgmatic-collective/borgmatic
borgmatic-collective
/
borgmatic
15
57
Fork 40
Code Issues 54 Pull Requests 1 Actions Packages Releases 121 Activity

Overrides are broken with old style config file #829

New Issue
Closed
opened 2024-02-15 21:13:56 +00:00 by kaysond · 4 comments
kaysond commented 2024-02-15 21:13:56 +00:00
Copy Link

What I'm trying to do and why

Run checks using an override

Steps to reproduce

borgmatic --config /etc/borgmatic.d/common/borgmatic.yml --log-file /var/log/borgmatic.log --log-file-verbosity 1 --verbosity 2 --override "consistency.checks=[{name: 'repository'}, {name: 'archives'}]" --repair check

config file:

location:
    one_file_system: true
    numeric_owner: true
    repositories:
        - ssh://x/mnt/arambkup/borg
        - /mnt/extdrive/borg

storage:
    compression: zstd,8
    encryption_passphrase: x
    ssh_command: ssh -i /root/.ssh/borg@x

retention:
    keep_daily: 7
    keep_weekly: 4
    keep_monthly: 2

consistency:
    checks:
        - name: disabled

hooks:
    healthchecks: https://com/ping/6621c7d8-1e54-4067-8ed9-45ec27f082f1

Actual behavior

Checks don't run:

BORG_PASSPHRASE=*** BORG_RSH=*** BORG_EXIT_CODES=*** borg --version --debug --show-rc
/etc/borgmatic.d/common/borgmatic.yml: Borg 1.2.7
/etc/borgmatic.d/common/borgmatic.yml: Calling healthchecks hook function initialize_monitor
/etc/borgmatic.d/common/borgmatic.yml: Calling healthchecks hook function ping_monitor
/etc/borgmatic.d/common/borgmatic.yml: Pinging Healthchecks start
/etc/borgmatic.d/common/borgmatic.yml: Using Healthchecks ping URL https://com/ping/d0df3540-ba11-49e3-9952-90be3470e2ff/start
ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg: Running actions for repository
/etc/borgmatic.d/common/borgmatic.yml: No commands to run for pre-actions hook
/etc/borgmatic.d/common/borgmatic.yml: No commands to run for pre-check hook
ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg: Running consistency checks
BORG_PASSPHRASE=*** BORG_RSH=*** BORG_EXIT_CODES=*** borg info --json ssh://x/mnt/arambkup/borg
The "disabled" value for the "checks" option is deprecated and will be removed from a future release; use "skip_actions" instead
/etc/borgmatic.d/common/borgmatic.yml: No commands to run for post-check hook
/etc/borgmatic.d/common/borgmatic.yml: No commands to run for post-actions hook
/mnt/extdrive/borg: Running actions for repository
/etc/borgmatic.d/common/borgmatic.yml: No commands to run for pre-actions hook
/etc/borgmatic.d/common/borgmatic.yml: No commands to run for pre-check hook
/mnt/extdrive/borg: Running consistency checks
BORG_PASSPHRASE=*** BORG_RSH=*** BORG_EXIT_CODES=*** borg info --json /mnt/extdrive/borg
The "disabled" value for the "checks" option is deprecated and will be removed from a future release; use "skip_actions" instead
/etc/borgmatic.d/common/borgmatic.yml: No commands to run for post-check hook
/etc/borgmatic.d/common/borgmatic.yml: No commands to run for post-actions hook
/etc/borgmatic.d/common/borgmatic.yml: Calling healthchecks hook function ping_monitor
/etc/borgmatic.d/common/borgmatic.yml: Pinging Healthchecks log
/etc/borgmatic.d/common/borgmatic.yml: Using Healthchecks ping URL https://com/ping/d0df3540-ba11-49e3-9952-90be3470e2ff/log
/etc/borgmatic.d/common/borgmatic.yml: Calling healthchecks hook function ping_monitor
/etc/borgmatic.d/common/borgmatic.yml: Pinging Healthchecks finish
/etc/borgmatic.d/common/borgmatic.yml: Using Healthchecks ping URL https://com/ping/d0df3540-ba11-49e3-9952-90be3470e2ff
/etc/borgmatic.d/common/borgmatic.yml: Calling healthchecks hook function destroy_monitor

summary:
/etc/borgmatic.d/common/borgmatic.yml: Loading configuration file
/etc/borgmatic.d/common/borgmatic.yml: Configuration sections (like location:, storage:, retention:, consistency:, and hooks:) are deprecated and support will be removed from a future release. To prepare for this, move your options out of sections to the global scope.
/etc/borgmatic.d/common/borgmatic.yml: The healthchecks hook now expects a key/value pair with "ping_url" as a key. String values for this option are deprecated and support will be removed from a future release.
/etc/borgmatic.d/common/borgmatic.yml: The numeric_owner option has been renamed to numeric_ids. numeric_owner is deprecated and support will be removed from a future release.
/etc/borgmatic.d/common/borgmatic.yml: The repositories option now expects a list of key/value pairs. Lists of strings for this option are deprecated and support will be removed from a future release.
/etc/borgmatic.d/common/borgmatic.yml: Successfully ran configuration file

Expected behavior

Checks should actually run

Other notes / implementation ideas

No response

borgmatic version

1.8.8

borgmatic installation method

pip

Borg version

1.2.7

Python version

3.9.2

Database version (if applicable)

No response

Operating system and version

Debian 11

### What I'm trying to do and why Run checks using an override ### Steps to reproduce `borgmatic --config /etc/borgmatic.d/common/borgmatic.yml --log-file /var/log/borgmatic.log --log-file-verbosity 1 --verbosity 2 --override "consistency.checks=[{name: 'repository'}, {name: 'archives'}]" --repair check` config file: ```yml location: one_file_system: true numeric_owner: true repositories: - ssh://x/mnt/arambkup/borg - /mnt/extdrive/borg storage: compression: zstd,8 encryption_passphrase: x ssh_command: ssh -i /root/.ssh/borg@x retention: keep_daily: 7 keep_weekly: 4 keep_monthly: 2 consistency: checks: - name: disabled hooks: healthchecks: https://com/ping/6621c7d8-1e54-4067-8ed9-45ec27f082f1 ``` ### Actual behavior Checks don't run: ``` BORG_PASSPHRASE=*** BORG_RSH=*** BORG_EXIT_CODES=*** borg --version --debug --show-rc /etc/borgmatic.d/common/borgmatic.yml: Borg 1.2.7 /etc/borgmatic.d/common/borgmatic.yml: Calling healthchecks hook function initialize_monitor /etc/borgmatic.d/common/borgmatic.yml: Calling healthchecks hook function ping_monitor /etc/borgmatic.d/common/borgmatic.yml: Pinging Healthchecks start /etc/borgmatic.d/common/borgmatic.yml: Using Healthchecks ping URL https://com/ping/d0df3540-ba11-49e3-9952-90be3470e2ff/start ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg: Running actions for repository /etc/borgmatic.d/common/borgmatic.yml: No commands to run for pre-actions hook /etc/borgmatic.d/common/borgmatic.yml: No commands to run for pre-check hook ssh://borg@borgvm.iyer.lan/mnt/arambkup/borg: Running consistency checks BORG_PASSPHRASE=*** BORG_RSH=*** BORG_EXIT_CODES=*** borg info --json ssh://x/mnt/arambkup/borg The "disabled" value for the "checks" option is deprecated and will be removed from a future release; use "skip_actions" instead /etc/borgmatic.d/common/borgmatic.yml: No commands to run for post-check hook /etc/borgmatic.d/common/borgmatic.yml: No commands to run for post-actions hook /mnt/extdrive/borg: Running actions for repository /etc/borgmatic.d/common/borgmatic.yml: No commands to run for pre-actions hook /etc/borgmatic.d/common/borgmatic.yml: No commands to run for pre-check hook /mnt/extdrive/borg: Running consistency checks BORG_PASSPHRASE=*** BORG_RSH=*** BORG_EXIT_CODES=*** borg info --json /mnt/extdrive/borg The "disabled" value for the "checks" option is deprecated and will be removed from a future release; use "skip_actions" instead /etc/borgmatic.d/common/borgmatic.yml: No commands to run for post-check hook /etc/borgmatic.d/common/borgmatic.yml: No commands to run for post-actions hook /etc/borgmatic.d/common/borgmatic.yml: Calling healthchecks hook function ping_monitor /etc/borgmatic.d/common/borgmatic.yml: Pinging Healthchecks log /etc/borgmatic.d/common/borgmatic.yml: Using Healthchecks ping URL https://com/ping/d0df3540-ba11-49e3-9952-90be3470e2ff/log /etc/borgmatic.d/common/borgmatic.yml: Calling healthchecks hook function ping_monitor /etc/borgmatic.d/common/borgmatic.yml: Pinging Healthchecks finish /etc/borgmatic.d/common/borgmatic.yml: Using Healthchecks ping URL https://com/ping/d0df3540-ba11-49e3-9952-90be3470e2ff /etc/borgmatic.d/common/borgmatic.yml: Calling healthchecks hook function destroy_monitor summary: /etc/borgmatic.d/common/borgmatic.yml: Loading configuration file /etc/borgmatic.d/common/borgmatic.yml: Configuration sections (like location:, storage:, retention:, consistency:, and hooks:) are deprecated and support will be removed from a future release. To prepare for this, move your options out of sections to the global scope. /etc/borgmatic.d/common/borgmatic.yml: The healthchecks hook now expects a key/value pair with "ping_url" as a key. String values for this option are deprecated and support will be removed from a future release. /etc/borgmatic.d/common/borgmatic.yml: The numeric_owner option has been renamed to numeric_ids. numeric_owner is deprecated and support will be removed from a future release. /etc/borgmatic.d/common/borgmatic.yml: The repositories option now expects a list of key/value pairs. Lists of strings for this option are deprecated and support will be removed from a future release. /etc/borgmatic.d/common/borgmatic.yml: Successfully ran configuration file ``` ### Expected behavior Checks should actually run ### Other notes / implementation ideas _No response_ ### borgmatic version 1.8.8 ### borgmatic installation method pip ### Borg version 1.2.7 ### Python version 3.9.2 ### Database version (if applicable) _No response_ ### Operating system and version Debian 11
kaysond commented 2024-02-15 21:15:06 +00:00
Author
Copy Link

There were a lot of messages about deprecated config styles, so I updated all of the config files I have, and things seem to work fine now. Figured I'd report this anyway just in case you want to fix it, but feel free to close.

There were a lot of messages about deprecated config styles, so I updated all of the config files I have, and things seem to work fine now. Figured I'd report this anyway just in case you want to fix it, but feel free to close.
witten commented 2024-02-16 03:17:50 +00:00
Owner
Copy Link

Thanks for bringing this to my attention! Based on some initial investigation, it looks like borgmatic supports overrides with deprecated section names applying to sectionless config or sectionless overrides applying to config with deprecated section names—but not overrides with deprecated section names applying to config with deprecated section names.

Just for the sake of completion, I'll look into how feasible it would be to fix this.

Thanks for bringing this to my attention! Based on some initial investigation, it looks like borgmatic supports overrides with deprecated section names applying to sectionless config _or_ sectionless overrides applying to config with deprecated section names—but not overrides with deprecated section names applying to config with deprecated section names. Just for the sake of completion, I'll look into how feasible it would be to fix this.
witten added the
bug
 label 2024-02-16 03:17:56 +00:00
witten commented 2024-02-16 05:13:16 +00:00
Owner
Copy Link

Fixed in main! Thanks again.

Fixed in main! Thanks again.
witten commented 2024-03-11 20:30:16 +00:00
Owner
Copy Link

Released in borgmatic 1.8.9!

Released in borgmatic 1.8.9!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
spot-check
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#829
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?