"Key in" should be "Key for" #823

New Issue

Closed

opened 2024-02-03 22:54:30 +00:00 by jonasstein · 2 comments

jonasstein commented 2024-02-03 22:54:30 +00:00

Copy Link

What I'm trying to do and why

After initialization with
borgmatic init -e repokey-blake2 -v2

I get

Key in "<RemoteRepository ssh://deadbeef@deadbeef.repo.borgbase.com/./repo>" created.
Keep this key safe. Your data will be inaccessible without it.

I think there is no key created in RemoteRepository. It should read

Key for "<RemoteRepository ssh://deadbeef@deadbeef.repo.borgbase.com/./repo>" created.
Keep this key safe. Your data will be inaccessible without it.

As we use different types of keys (SSH Key, Repokey, Passphrase...) here it would be useful to name the key.

Steps to reproduce

No response

Actual behavior

No response

Expected behavior

No response

Other notes / implementation ideas

No response

borgmatic version

1.8.5

borgmatic installation method

Gentoo package

Borg version

borg 1.2.7

Python version

Python 3.11.7

Database version (if applicable)

No response

Operating system and version

Gentoo Linux

### What I'm trying to do and why After initialization with `borgmatic init -e repokey-blake2 -v2` I get ``` Key in "<RemoteRepository ssh://deadbeef@deadbeef.repo.borgbase.com/./repo>" created. Keep this key safe. Your data will be inaccessible without it. ``` I think there is no key created in RemoteRepository. It should read ``` Key for "<RemoteRepository ssh://deadbeef@deadbeef.repo.borgbase.com/./repo>" created. Keep this key safe. Your data will be inaccessible without it. ``` As we use different types of keys (SSH Key, Repokey, Passphrase...) here it would be useful to name the key. ### Steps to reproduce _No response_ ### Actual behavior _No response_ ### Expected behavior _No response_ ### Other notes / implementation ideas _No response_ ### borgmatic version 1.8.5 ### borgmatic installation method Gentoo package ### Borg version borg 1.2.7 ### Python version Python 3.11.7 ### Database version (if applicable) _No response_ ### Operating system and version Gentoo Linux

witten commented 2024-02-03 23:01:03 +00:00

Owner

Copy Link

Thanks for taking the time to file this (and work through the registration system issues)! As suspected, I can confirm that this message is coming directly from Borg, and therefore I recommend filing the issue with that project if you'd like to see a change with the message. It's possible though that Borg says "key in" because, if my understanding is correct, "repokey-blake2" actually does create a key and store it inside the repository. See https://borgbackup.readthedocs.io/en/stable/usage/init.html#encryption-mode-tldr for more information.

Thanks for taking the time to file this (and work through the registration system issues)! As suspected, I can confirm that this message is coming directly from Borg, and therefore I recommend filing the issue with that project if you'd like to see a change with the message. It's possible though that Borg says "key in" because, if my understanding is correct, "repokey-blake2" actually does create a key and store it *inside* the repository. See https://borgbackup.readthedocs.io/en/stable/usage/init.html#encryption-mode-tldr for more information.

witten added the

question / support

label 2024-02-03 23:01:53 +00:00

witten commented 2024-02-26 17:10:37 +00:00

Owner

Copy Link

Closing for now, but please let me know if you have any other feedback on this! Thanks.

Closing for now, but please let me know if you have any other feedback on this! Thanks.

witten closed this issue 2024-02-26 17:10:38 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#823

No description provided.