borg check --max-duration support #817

New issue

Closed

opened 2024-01-19 19:46:20 +00:00 by witten · 6 comments

witten commented 2024-01-19 19:46:20 +00:00

Owner

Copy link

What I'd like to do and why

As part of this ticket, implement borgmatic support for borg check --max-duration, either as a configuration option or a command-line flag or both.

Other notes / implementation ideas

Split off from #814. A comment by @tehNiemer from there:

I think supporting --max-duration natively in both/either the config and command line won't hurt anything, I personally would like to be able to run any borg command from borgmatic natively, but that's probably a tall order. The only potential hiccup I see with --max-duration is that it can only be run on repositories, so if there were additional checks in the configuration, they would have to be called separately from repository checks within borgmatic.

### What I'd like to do and why As part of this ticket, implement borgmatic support for `borg check --max-duration`, either as a configuration option or a command-line flag or both. ### Other notes / implementation ideas Split off from #814. A comment by @tehNiemer from there: > I think supporting --max-duration natively in both/either the config and command line won't hurt anything, I personally would like to be able to run any borg command from borgmatic natively, but that's probably a tall order. The only potential hiccup I see with --max-duration is that it can only be run on repositories, so if there were additional checks in the configuration, they would have to be called separately from repository checks within borgmatic.

witten added the

good first issue

label 2024-01-19 19:47:02 +00:00

witten referenced this issue 2024-01-19 19:49:12 +00:00

Use of the borg option "--max-duration" in borgmatic is not behaving as expected. #814

haanhvu commented 2024-02-09 14:18:18 +00:00

Copy link

I'll work on this

I'll work on this

witten commented 2024-02-09 17:47:23 +00:00

Author

Owner

Copy link

Great! I'm happy to brainstorm on your approach before you get started if that helps.

Great! I'm happy to brainstorm on your approach before you get started if that helps.

xLogiiCx commented 2024-03-05 15:32:56 +00:00

Copy link

Hi, would like this feature too.
@haanhvu whats the Status? Do you need help or advice?

Hi, would like this feature too. @haanhvu whats the Status? Do you need help or advice?

witten added the

waiting for response

label 2024-03-12 21:12:18 +00:00

witten removed the

waiting for response

label 2024-05-17 15:59:04 +00:00

witten commented 2024-05-17 15:59:37 +00:00

Author

Owner

Copy link

@haanhvu I'll assume at this point that you're not planning on working on this one, but please let me know if that's incorrect! Thanks.

@haanhvu I'll assume at this point that you're not planning on working on this one, but please let me know if that's incorrect! Thanks.

witten referenced this issue from a commit 2024-06-22 23:19:25 +00:00

Add a "--max-duration" flag to the "check" action and a "max_duration" option to the repository check configuration (#817).

witten commented 2024-06-22 23:19:51 +00:00

Author

Owner

Copy link

Implemented in main and will be part of the next release!

Implemented in main and will be part of the next release!

witten 2024-06-22 23:19:51 +00:00

• closed this issue
• removed the
  good first issue
  label

witten commented 2024-06-24 00:05:11 +00:00

Author

Owner

Copy link

Released in borgmatic 1.8.12!

Released in borgmatic 1.8.12!

witten referenced this issue 2024-06-25 22:01:03 +00:00

Is --max-duration for checks supported by YAML already? #506

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

parallel-borgmatic

command-hook-steps

2.1.7

2.1.6

2.1.5

2.1.4

2.1.3

2.1.2

2.1.1

2.1.0

2.0.13

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.7

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.9.14

1.9.13

1.9.12

1.9.11

1.9.10

1.9.9

1.9.8

1.9.7

1.9.6

1.9.5

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.14

1.8.13

1.8.12

1.8.11

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

blocked

  

breaking

  

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No labels

blocked

breaking

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

borgmatic-collective/borgmatic#817

No description provided.