Add token auth for ntfy hook #811

New Issue

Closed

opened 2024-01-08 08:31:11 +00:00 by melsophos · 4 comments

melsophos commented 2024-01-08 08:31:11 +00:00

Copy Link

What I'd like to do and why

On a private server, ntfy recommends using authentication with tokens instead of user and password, so I was wondering if it would be possible to add this option?
Moreover, it would be useful if the script could get the default server and token (or username/pwd) from the client.yml files:

~/.config/ntfy/client.yml
/etc/ntfy/client.yml

Other notes / implementation ideas

No response

### What I'd like to do and why On a private server, ntfy recommends using authentication with tokens instead of user and password, so I was wondering if it would be possible to add this option? Moreover, it would be useful if the script could get the default server and token (or username/pwd) from the `client.yml` files: ``` ~/.config/ntfy/client.yml /etc/ntfy/client.yml ``` ### Other notes / implementation ideas _No response_

witten commented 2024-01-08 17:55:50 +00:00

Owner

Copy Link

Using authentication tokens with ntfy makes sense to me. I'm not sure about client.yml though because borgmatic doesn't use the ntfy client, so it'd be a little weird to use its configuration file. Additionally, that configuration file wouldn't be covered by borgmatic's bootstrapping. Is the idea that you just don't want to maintain the ntfy authentication token in two different places?

Using authentication tokens with ntfy makes sense to me. I'm not sure about `client.yml` though because borgmatic doesn't use the ntfy client, so it'd be a little weird to use its configuration file. Additionally, that configuration file wouldn't be covered by [borgmatic's bootstrapping](https://torsion.org/borgmatic/docs/how-to/extract-a-backup/#extract-the-configuration-files-used-to-create-an-archive). Is the idea that you just don't want to maintain the ntfy authentication token in two different places?

melsophos commented 2024-01-08 18:02:34 +00:00

Author

Copy Link

My motivation for using client.yml to avoid writing the token if for limiting the risk of exposing its value. But I just understood that one can create different tokens for a single user, so in this case one can create a token for borgmatic only, and revoke it if compromised. Also you have an excellent point with the bootstrapping.

My motivation for using `client.yml` to avoid writing the token if for limiting the risk of exposing its value. But I just understood that one can create different tokens for a single user, so in this case one can create a token for borgmatic only, and revoke it if compromised. Also you have an excellent point with the bootstrapping.

👍 1

witten referenced this issue from a commit 2024-03-11 19:49:15 +00:00

Add an "access_token" option to the ntfy monitoring hook for authenticating without username/password (#811).

witten commented 2024-03-11 19:49:46 +00:00

Owner

Copy Link

This has been implemented in main (as a new access_token option) and will be part of the next release! Thanks for the suggestion.

This has been implemented in main (as a new `access_token` option) and will be part of the next release! Thanks for the suggestion.

❤️ 1

witten closed this issue 2024-03-11 19:49:47 +00:00

witten commented 2024-03-11 20:29:57 +00:00

Owner

Copy Link

Released in borgmatic 1.8.9!

Released in borgmatic 1.8.9!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

spot-check

1.8.10

1.8.9

1.8.8

1.8.7

1.8.6

1.8.5

1.8.4

1.8.3

1.8.2

1.8.1

1.8.0

1.7.15

1.7.14

1.7.13

1.7.12

1.7.11

1.7.10

1.7.9

1.7.8

1.7.7

1.7.6

1.7.5

1.7.4

1.7.3

1.7.2

1.7.1

1.7.0

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.24

1.5.23

1.5.22

1.5.21

1.5.20

1.5.19

1.5.18

1.5.17

1.5.16

1.5.15

1.5.14

1.5.13

1.5.12

1.5.11

1.5.10

1.5.9

1.5.8

1.5.7

1.5.7.dev0

1.5.6

1.5.5

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.22

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.26

1.3.25

1.3.24

1.3.23

1.3.22

1.3.21

1.3.20

1.3.19

1.3.18

1.3.17

1.3.16

1.3.15

1.3.14

1.3.13

1.3.12

1.3.11

1.3.10

1.3.9

1.3.8

1.3.7

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.18

1.2.17

1.2.16

1.2.15

1.2.14

1.2.13

1.2.12

1.2.11

1.2.10

1.2.9

1.2.8

1.2.7

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.15

1.1.14

1.1.13

1.1.12

1.1.11

1.1.10

1.1.9

1.1.7

1.1.6

1.1.5

1.1.4

1.1.3

1.1.2

1.1.1

1.1.0

1.0.3

1.0.2

1.0.1

1.0.0

0.1.8

0.1.7

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

0.0.7

0.0.6

0.0.5

0.0.4

0.0.3

0.0.2

Labels

Clear labels   

bug

  

data loss

  

design finalized

  

good first issue

  

new feature area

  

question / support

  

security

  

waiting for response

No Label

bug

data loss

design finalized

good first issue

new feature area

question / support

security

waiting for response

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: borgmatic-collective/borgmatic#811

No description provided.