"borgmatic config validate" reports valid even when config is invalid #804

New issue

Closed

opened 2023-12-28 23:27:44 +00:00 by nfp0 · 5 comments

nfp0 commented

2023-12-28 23:27:44 +00:00

What I'm trying to do and why

Writing an invalid value on the skip_actions section is considered valid by the borgmatic config validate command.

For example, running that command on a config file with the following section:

skip_actions:
    - sdfkjfjieojf

Still reports as valid:

summary:
All configuration files are valid

And execution even runs as normal. It seems to ignore the value.

### What I'm trying to do and why Writing an invalid value on the skip_actions section is considered valid by the `borgmatic config validate` command. For example, running that command on a config file with the following section: ``` skip_actions: - sdfkjfjieojf ``` Still reports as valid: ``` summary: All configuration files are valid ``` And execution even runs as normal. It seems to ignore the value.

witten commented

2023-12-28 23:58:36 +00:00

Owner

Thanks for filing this one as well! I think the fix here is probably to update the configuration schema to explicitly declare the allowed actions. Then borgmatic config validate will likely complain if an unsupported action is used.

Implementation note: One risk is that this hard-coded action list could drift from the actual implemented actions over time. So it might be a good idea to add an automated test to detect this case and error if it occurs.

Thanks for filing this one as well! I think the fix here is probably to update the configuration schema to explicitly declare the allowed actions. Then `borgmatic config validate` will likely complain if an unsupported action is used. Implementation note: One risk is that this hard-coded action list could drift from the actual implemented actions over time. So it might be a good idea to add an automated test to detect this case and error if it occurs.

👍 1

witten added the

good first issue

label

2023-12-28 23:58:42 +00:00

nfp0 commented

2023-12-29 00:13:20 +00:00

Author

Sounds like a solid plan!

witten referenced this issue from a commit

2023-12-29 04:08:13 +00:00

Validate the configured action names in the "skip_actions" option (#804).