"borgmatic config validate" reports valid even when config is invalid #804
Labels
No Label
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: borgmatic-collective/borgmatic#804
Loadingβ¦
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What I'm trying to do and why
Writing an invalid value on the skip_actions section is considered valid by the
borgmatic config validate
command.For example, running that command on a config file with the following section:
Still reports as valid:
And execution even runs as normal. It seems to ignore the value.
Thanks for filing this one as well! I think the fix here is probably to update the configuration schema to explicitly declare the allowed actions. Then
borgmatic config validate
will likely complain if an unsupported action is used.Implementation note: One risk is that this hard-coded action list could drift from the actual implemented actions over time. So it might be a good idea to add an automated test to detect this case and error if it occurs.
Sounds like a solid plan!
This has been implemented in main and will be part of the next release!
Sweet! Thank you for the quick fix! π
Released in borgmatic 1.8.6!