borgmatic-collective/borgmatic
borgmatic-collective/borgmatic
Watch
9
74
Fork
You've already forked borgmatic
 57
Code Issues 71 Pull requests 3 Releases 162 Packages 1 Activity Actions 1

"borgmatic check --force" does nothing if config is set to skip checks #802

New issue
Closed
opened 2023-12-28 16:09:47 +00:00 by nfp0 Β· 5 comments
nfp0 commented 2023-12-28 16:09:47 +00:00
Copy link

What I'm trying to do and why

I'm trying to force check my repository, but the command ends instantly and no check is performed, even with the --only option specified.

For example, the command
borgmatic check --force --verbosity 1 --only archives
ends instantaneously with the output:

summary:
/home/myhome/.config/borgmatic/config.yaml: Successfully ran configuration file

After I removed

skip_actions:
    - check

from my config file, the check worked.

Is this intentional or a bug?
The documentation states I can use the --force option to ignore the config and execute any arbitrary check I want.

### What I'm trying to do and why I'm trying to force check my repository, but the command ends instantly and no check is performed, even with the `--only` option specified. For example, the command `borgmatic check --force --verbosity 1 --only archives` ends instantaneously with the output: ``` summary: /home/myhome/.config/borgmatic/config.yaml: Successfully ran configuration file ``` After I removed ``` skip_actions: - check ``` from my config file, the check worked. Is this intentional or a bug? The documentation states I can use the `--force` option to ignore the config and execute any arbitrary check I want.
witten commented 2023-12-28 17:29:20 +00:00
Owner
Copy link

Thanks for filing this! The behavior you're seeing is not intentional, but whether it's a bug is subject to interpretation. πŸ˜„ That's because the skip_actions feature was added well after the check --force feature was implemented and documented, and the two features are therefore entirely independent. I will say though that your user expectation (that check --force overrides skip_actions) seems reasonable to me. I'll have a look at how difficult that would be to implement.

Thanks for filing this! The behavior you're seeing is not intentional, but whether it's a bug is subject to interpretation. πŸ˜„ That's because the `skip_actions` feature was added well after the `check --force` feature was implemented and documented, and the two features are therefore entirely independent. I will say though that your user expectation (that `check --force` overrides `skip_actions`) seems reasonable to me. I'll have a look at how difficult that would be to implement.
nfp0 commented 2023-12-28 17:43:17 +00:00
Author
Copy link

Thank you for the feedback! πŸ™‚

Yes, indeed my expectation is that there is a way to have checks disabled on the config file (because they take too long, for example), but still have a way to force check them at an arbitrary moment of my choice.
The current way requires the user to temporarily modify it's config file, which IMO is not a good thing.

Thank you for this excellent software, and I hope you find a way to work around this!

Thank you for the feedback! πŸ™‚ Yes, indeed my expectation is that there is a way to have checks disabled on the config file (because they take too long, for example), but still have a way to force check them at an arbitrary moment of my choice. The current way requires the user to temporarily modify it's config file, which IMO is not a good thing. Thank you for this excellent software, and I hope you find a way to work around this!
πŸ‘ 1
witten commented 2023-12-28 18:23:31 +00:00
Owner
Copy link

This is implemented in main and will be part of the next release. Thanks again for bringing this to my attention!

This is implemented in main and will be part of the next release. Thanks again for bringing this to my attention!
πŸŽ‰ 1
nfp0 commented 2023-12-28 18:34:37 +00:00
Author
Copy link

Fantastic! Couldn't hope for a faster response. Many thanks! πŸ™‚

Fantastic! Couldn't hope for a faster response. Many thanks! πŸ™‚
πŸ‘ 1
witten commented 2024-01-03 18:12:37 +00:00
Owner
Copy link

Released in borgmatic 1.8.6!

Released in borgmatic 1.8.6!
πŸŽ‰ 1
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
parallel-borgmatic
command-hook-steps
2.1.7
2.1.6
2.1.5
2.1.4
2.1.3
2.1.2
2.1.1
2.1.0
2.0.13
2.0.12
2.0.11
2.0.10
2.0.9
2.0.8
2.0.7
2.0.6
2.0.5
2.0.4
2.0.3
2.0.2
2.0.1
2.0.0
1.9.14
1.9.13
1.9.12
1.9.11
1.9.10
1.9.9
1.9.8
1.9.7
1.9.6
1.9.5
1.9.4
1.9.3
1.9.2
1.9.1
1.9.0
1.8.14
1.8.13
1.8.12
1.8.11
1.8.10
1.8.9
1.8.8
1.8.7
1.8.6
1.8.5
1.8.4
1.8.3
1.8.2
1.8.1
1.8.0
1.7.15
1.7.14
1.7.13
1.7.12
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.24
1.5.23
1.5.22
1.5.21
1.5.20
1.5.19
1.5.18
1.5.17
1.5.16
1.5.15
1.5.14
1.5.13
1.5.12
1.5.11
1.5.10
1.5.9
1.5.8
1.5.7
1.5.7.dev0
1.5.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.22
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.26
1.3.25
1.3.24
1.3.23
1.3.22
1.3.21
1.3.20
1.3.19
1.3.18
1.3.17
1.3.16
1.3.15
1.3.14
1.3.13
1.3.12
1.3.11
1.3.10
1.3.9
1.3.8
1.3.7
1.3.6
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.18
1.2.17
1.2.16
1.2.15
1.2.14
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
0.0.7
0.0.6
0.0.5
0.0.4
0.0.3
0.0.2
Labels
Clear labels   
blocked

   
breaking

   
bug

   
data loss

   
design finalized

   
good first issue

   
new feature area

   
question / support

   
security

   
waiting for response
No labels
blocked
breaking
bug
data loss
design finalized
good first issue
new feature area
question / support
security
waiting for response
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
borgmatic-collective/borgmatic#802
No description provided.